From fbb3b6cda5b4ac4c059b71ac6ee198f58c529a81 Mon Sep 17 00:00:00 2001 From: Ben Fulton Date: Tue, 7 Apr 2026 13:34:51 -0400 Subject: [PATCH] fix: add service annotations support to `metaflow-ui` services The `metaflow-service` subchart already supports `service.annotations`, but the `metaflow-ui` subchart does not. This makes it impossible to set per-service annotations like ALB healthcheck paths when deploying with the AWS Load Balancer Controller. Add `{{- with .Values.uiBackend.service.annotations }}` and `{{- with .Values.uiStatic.service.annotations }}` blocks to the backend and static service templates, matching the existing pattern in `metaflow-service/templates/service.yaml`. --- .../charts/metaflow-ui/templates/backend_service.yaml | 4 ++++ .../metaflow/charts/metaflow-ui/templates/static_service.yaml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/charts/metaflow/charts/metaflow-ui/templates/backend_service.yaml b/charts/metaflow/charts/metaflow-ui/templates/backend_service.yaml index 50dd93b..669ac8a 100644 --- a/charts/metaflow/charts/metaflow-ui/templates/backend_service.yaml +++ b/charts/metaflow/charts/metaflow-ui/templates/backend_service.yaml @@ -5,6 +5,10 @@ metadata: namespace: {{ .Values.namespace }} labels: {{- include "metaflow-ui.labels" . | nindent 4 }} + {{- with .Values.uiBackend.service.annotations }} + annotations: + {{- toYaml . | nindent 4 }} + {{- end }} spec: type: {{ .Values.uiBackend.service.type }} ports: diff --git a/charts/metaflow/charts/metaflow-ui/templates/static_service.yaml b/charts/metaflow/charts/metaflow-ui/templates/static_service.yaml index 425572e..5fe8a5e 100644 --- a/charts/metaflow/charts/metaflow-ui/templates/static_service.yaml +++ b/charts/metaflow/charts/metaflow-ui/templates/static_service.yaml @@ -5,6 +5,10 @@ metadata: namespace: {{ .Values.namespace | default "default" }} labels: {{- include "metaflow-ui.labelsStatic" . | nindent 4 }} + {{- with .Values.uiStatic.service.annotations }} + annotations: + {{- toYaml . | nindent 4 }} + {{- end }} spec: type: {{ .Values.uiStatic.service.type }} loadBalancerIP: {{ .Values.uiStatic.service.loadBalancerIP | default "" }}