Missing element in aggregation for prometheus format

[outscale-mdr]

Hello team,

I end up with a strange bug, when I was testing aggregation of resources I found that the prometheus format was missing some resources.

Here is the output for other format:

outscale:~/Sources$ osc-cost --profile cloud-gouv-1  --aggregate
Summary:
╭───────────────────────┬──────────────╮
│ Account Id            ┆ XXX │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Total price per hour  ┆ 0.106027395€ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Total price per month ┆ 77.4€        │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Total price per year  ┆ 928.80005€   │
╰───────────────────────┴──────────────╯

Details:
╭───────────────┬───────┬──────────────────────┬───────────────────────┬──────────────────────╮
│ Resource Type ┆ Count ┆ Total price per hour ┆ Total price per month ┆ Total price per year │
╞═══════════════╪═══════╪══════════════════════╪═══════════════════════╪══════════════════════╡
│ Snapshot      ┆ 31    ┆ 0.028027391€         ┆ 20.459997€            ┆ 245.51996€           │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ PublicIp      ┆ 13    ┆ 0.078€               ┆ 56.94001€             ┆ 683.28015€           │
╰───────────────┴───────┴──────────────────────┴───────────────────────┴──────────────────────╯
outscale:~/Sources$ osc-cost --profile cloud-gouv-1  --aggregate --format json
{"resource_type":"Aggregate","osc_cost_version":"0.2.0","account_id":"XXX","read_date_rfc3339":"2023-10-11T11:25:45.159124566+00:00","region":"cloudgouv-eu-west-1","price_per_hour":0.028027391,"price_per_month":20.459997,"aggregated_resource_type":"Snapshot","count":31}
{"resource_type":"Aggregate","osc_cost_version":"0.2.0","account_id":"XXX","read_date_rfc3339":"2023-10-11T11:25:45.159124566+00:00","region":"cloudgouv-eu-west-1","price_per_hour":0.078,"price_per_month":56.94001,"aggregated_resource_type":"PublicIp","count":13}

But in the prometheus format, PublicIpis missing:

outscale:~/Sources$ osc-cost --profile cloud-gouv-1  --aggregate --format prometheus
# HELP Aggregate_price_hour Aggregate price by hour
# TYPE Aggregate_price_hour gauge
Aggregate_price_hour{account_id="XXX",aggregated_resource_type="Snapshot",osc_cost_version="0.2.0",region="cloudgouv-eu-west-1",resource_type="Aggregate"} 0.028027391
# HELP Aggregate_price_month Aggregate price by month
# TYPE Aggregate_price_month gauge
Aggregate_price_month{account_id="XXX",aggregated_resource_type="Snapshot",osc_cost_version="0.2.0",region="cloudgouv-eu-west-1",resource_type="Aggregate"} 20.459997

Best regards

Hi @outscale-mdr
I try to reproduce your bug with the same condition (cloudgouv, snapshot and publicip) and i get the publicIp in both josn and prometheus format.

./osc-cost --format=json
hello there false
{"resource_type":"PublicIp","osc_cost_version":"0.3.3","account_id":"xxxxxx","read_date_rfc3339":"2023-10-16T12:38:34.258217023+00:00","region":"cloudgouv-eu-west-1","resource_id":"eipalloc-f7c8fb40","price_per_hour":0.006,"price_per_month":4.38,"price_non_attached":0.006,"price_first_ip":null,"price_next_ips":null}

{"resource_type":"Snapshot","osc_cost_version":"0.3.3","account_id":"xxxxx","read_date_rfc3339":"2023-10-16T12:38:34.258217023+00:00","region":"cloudgouv-eu-west-1","resource_id":"snap-96823196","price_per_hour":0.00090410956,"price_per_month":0.65999997,"volume_size_gib":10,"price_gb_per_month":0.066}

./osc-cost --format=prometheus
hello there false
# HELP PublicIp_price_hour PublicIp price by hour
# TYPE PublicIp_price_hour gauge
PublicIp_price_hour{account_id="xxxxxx",osc_cost_version="0.3.3",region="cloudgouv-eu-west-1",resource_id="eipalloc-10cba4c8",resource_type="PublicIp"} 0.006

# HELP PublicIp_price_month PublicIp price by month
# TYPE PublicIp_price_month gauge
PublicIp_price_month{account_id="xxxxxx",,osc_cost_version="0.3.3",region="cloudgouv-eu-west-1",resource_id="eipalloc-10cba4c8",resource_type="PublicIp"} 4.38

# HELP Snapshot_price_hour Snapshot price by hour
# TYPE Snapshot_price_hour gauge
Snapshot_price_hour{account_id="xxxxxx",osc_cost_version="0.3.3",region="cloudgouv-eu-west-1",resource_id="snap-0859de13",resource_type="Snapshot"} 0.00090410956

# HELP Snapshot_price_month Snapshot price by month
# TYPE Snapshot_price_month gauge
Snapshot_price_month{account_id="xxxxxx",osc_cost_version="0.3.3",region="cloudgouv-eu-west-1",resource_id="snap-0859de13",resource_type="Snapshot"} 0.65999997

[outscale-mdr]

Hi @outscale-vbr ,

I think you forgot the --aggregate parameter, can you try again ?

I've retested with the 0.3.5 binary and still the same