Skip to content

Compacting Upgrade + Filter = Item Deletion #18

@ztk4

Description

@ztk4

Observed Behavior:

If you install a compacting upgrade into a krate with a global filter (the top left slot in the GUI), if the resulting compact form is not in the filter the crafting result is deleted.

Expected Behavior:

Under no circumstances would the krate mod delete items permanently. At worst I would expect items to be dropped in world...

Steps to reproduce:

  1. Put a stack of iron ingots in a krate (of any size).
  2. Create a krate filter that only matches iron ingots:
    • Whitelist mode
    • Ignore Tags
    • Ignore NBT
    • Items: Iron Ingot
  3. Place the filter from (2) into the global filter slot (in the top left of the GUI) for the krate from (1)
  4. Place a compacting upgrade into the krate from (1) -- should default to 3x3 mode.
  5. <observe>: Instead of crafting iron blocks, iron ingots will be deleted in batches of 9.

Possible Fixes:

  • Fail to compact (i.e. do nothing) if the result of a compacting would not match the current krate's global filter -- my preferred solution. As a bonus, this could let you filter which compaction results you want krate to consider making.
  • Place the compaction results into the krate anyway, even though they don't match the filter -- seems alright... but isn't consistent with other mod behaviors.
  • Drop the compaction results as items in the world if they don't match the filter -- my least favorite solution, this is just tough to deal with in a useful way.

Details:

Type Detail
Pack Oceanblock 1.6.0
Hosting Dedicated windows server + dedicated windows client
Mod Version Krate-1.16.5-0.1.4.jar

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions