[New arch] Use Moshi to parse capabilities and get rid of RemoteCapability in library?

[davigonz]

GetRemoteCapabilitiesOperation.kt takes care of parsing the capabilities retrieved from the server in JSON format and transform them into RemoteCapability object.

Similarly to what we detailed in #2704, we could use Moshi to make the parsing of capabilities.

IN ADDITION

Since RemoteCapability object and OCCapability (domain model) objects are going to represent basically the same (when modularization is finished), we could get rid of RemoteCapability and parse the JSON directly to OCCapability from the data layer.

Parsing JSON and transforming it to domain models in data layer is the most common scenario when connecting with external APIs but ownCloud for Android is a special case, we have an intermediate layer between the oC server and our app, which is the ownCloud Android Library. This library is meant to make the life easier to those interested in communicate an Android app with ownCloud servers.

If we remove RemoteCapability from the ownCloud Android Library, the apps using it will receive just JSON and would need to parse it, so maybe is not the best idea if the aim of the library is "integrating your Android application with ownCloud seamlessly." 🤔

Tasks:

• Move capabilities parsing from library to data layer, that will parse the JSON and transform it into OCCapability object. This OCCapability object is the domain model that will be retrieved from the data layer.
• Get rid of RemoteCapability class in library since is basically the same as OCCapability

PR

• App: Use moshi to parse capabilities (Library Update) #2860
• Library: Use Moshi to parse Capabilities android-library#298

[abelgardep]

Capabilities

It would be good to know which capabilities are mandatory and are always sent to the client, and which are optional.

Unused capabilities

There are two capabilities that are not being used anywhere. Should we remove them?
filesSharingPublicSendMail
filesSharingUserSendMail

RemoteCapability

It is a simple facade of OCCapability inside Library. From my point of view, it can be removed. This way, the operation would return a CapabilityResponse which would be mapped to model(OCCapability) at OCRemoteCapabilitiesDataSource

[davigonz]

@jesmrec ready to test

[abelgardep]

Unused capabilities

There are two capabilities that are not being used anywhere. Should we remove them?
filesSharingPublicSendMail
filesSharingUserSendMail

What should we do with those capabilities? @michaelstingl @jesmrec @davigonz

[jesmrec]

What should we do with those capabilities? @michaelstingl @jesmrec @davigonz

Remove them (and any other) if they are not useful, please. Afaik, those capabilites are used to send a mail to the recipient when something is shared. This is nothing we are handling in the mobile apps.

[abelgardep]

Unused capabilities removed and tests updated.

[abelgardep]

I have split the issue into two separated PR:

Use moshi to parse capabilities:

• App: Use moshi to parse capabilities (Library Update) #2860 Library: Use Moshi to parse Capabilities android-library#298

Remove unused capabilities:

• App: Removed unused capabilities and update tests #2874 Library: Removed unused capabilities android-library#318