Skip to content

[substrate-node-new] pipefail side effect #41

@elenoir

Description

@elenoir

Hi,

In #40, you activated the script exiting in case a command does not end well with set -eo pipefail
I faced a side effect of this after bootstrapping a fresh Virtual Machine and trying to install substrate ; indeed, my git was not configured (user.email/user.name) so the line git commit -a -m "Initial clone from template node" 2>/dev/null >/dev/null fails.
As the standard and error outputs are not shown, it was a pain to understand why my node did not install.

Maybe we should remove these 2> /dev/null no?
Please give me your opinion and I will submit a PR if needed.

Thanks !

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions