Skip to content

Commit 04afbf8

Browse files
committed
fix(ci): use Nx aggregate targets for integration and e2e jobs
Replace manual registry:install + individual test commands with integration-all and e2e-all Nx targets. These fan out to per-fixture targets with install-fixture dependencies handled by Nx's task runner. Removes redundant SKIP_SETUP and separate install steps.
1 parent a498b89 commit 04afbf8

1 file changed

Lines changed: 2 additions & 14 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,11 @@ jobs:
5757
- name: Wait for Verdaccio
5858
run: npx wait-on http://localhost:4873 --timeout 30000
5959

60-
- name: Authenticate to local registry
61-
run: npm config set //localhost:4873/:_authToken dummy-token
62-
6360
- name: Publish to local registry
6461
run: pnpm run registry:publish:only
6562

66-
- name: Install fixtures
67-
run: pnpm run registry:install
68-
6963
- name: Run integration tests
70-
run: npx nx integration domscribe-test-fixtures
64+
run: npx nx run domscribe-test-fixtures:integration-all
7165

7266
e2e:
7367
runs-on: ubuntu-latest
@@ -99,17 +93,11 @@ jobs:
9993
- name: Wait for Verdaccio
10094
run: npx wait-on http://localhost:4873 --timeout 30000
10195

102-
- name: Authenticate to local registry
103-
run: npm config set //localhost:4873/:_authToken dummy-token
104-
10596
- name: Publish to local registry
10697
run: pnpm run registry:publish:only
10798

108-
- name: Install fixtures
109-
run: pnpm run registry:install
110-
11199
- name: Run e2e tests
112-
run: SKIP_SETUP=1 npx nx e2e domscribe-test-fixtures
100+
run: npx nx run domscribe-test-fixtures:e2e-all
113101

114102
- name: Upload Playwright report
115103
if: failure()

0 commit comments

Comments
 (0)