Skip to content

Commit 07de1b5

Browse files
committed
fix - ignore menu item events in datalist
1 parent 36b3257 commit 07de1b5

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

packages/react-core/src/components/DataList/DataListItem.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { Children, Component, cloneElement, isValidElement } from 'react';
22
import { css } from '@patternfly/react-styles';
33
import styles from '@patternfly/react-styles/css/components/DataList/data-list';
4+
import menuStyles from '@patternfly/react-styles/css/components/Menu/menu';
45
import { DataListContext } from './DataList';
56
import { KeyTypes } from '../../helpers/constants';
67

@@ -65,8 +66,10 @@ class DataListItem extends Component<DataListItemProps> {
6566

6667
const onKeyDown = (event: React.KeyboardEvent) => {
6768
if ([KeyTypes.Enter, KeyTypes.Space].includes(event.key)) {
68-
const target: any = event.target;
69+
const target: any = event.target as HTMLElement;
70+
6971
if (
72+
target.closest(`.${menuStyles.menuItem}`) ||
7073
target.parentNode.classList.contains(styles.dataListItemAction) ||
7174
target.parentNode.classList.contains(styles.dataListItemControl)
7275
) {

0 commit comments

Comments
 (0)