Skip to content

Commit 3e5381a

Browse files
committed
update nav toggle handler
1 parent 6f45eda commit 3e5381a

2 files changed

Lines changed: 16 additions & 20 deletions

File tree

packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ export const CompassDockDemo: React.FunctionComponent = () => {
111111
const onNavSelect = (_event: React.FormEvent<HTMLInputElement>, selectedItem: NavOnSelectProps) => {
112112
typeof selectedItem.itemId === 'number' && setActiveItem(selectedItem.itemId);
113113

114-
setIsNavGroupExpanded(false);
115114
setIsDockExpandableExpanded(false);
116115
setIsDockTextExpanded(false);
117116
setIsDockExpanded(false);
@@ -161,11 +160,12 @@ export const CompassDockDemo: React.FunctionComponent = () => {
161160
}
162161
};
163162

164-
const onToggleNavGroup = (
165-
_event: React.MouseEvent<HTMLButtonElement>,
166-
result: { groupId: number | string; isExpanded: boolean }
167-
) => {
168-
setIsNavGroupExpanded(result.isExpanded);
163+
const onToggleNavGroup = (_event: React.MouseEvent<HTMLButtonElement>, isExpanded: boolean) => {
164+
if (!isDockExpandableExpanded) {
165+
setIsNavGroupExpanded(true);
166+
} else {
167+
setIsNavGroupExpanded(isExpanded);
168+
}
169169

170170
if (!isMobile) {
171171
if (!isDockExpandableExpanded && !isDockTextExpanded) {
@@ -326,13 +326,7 @@ export const CompassDockDemo: React.FunctionComponent = () => {
326326
<Toolbar id="toolbar" isVertical>
327327
<ToolbarContent>
328328
<ToolbarItem>
329-
<Nav
330-
onSelect={onNavSelect}
331-
onToggle={onToggleNavGroup}
332-
variant="docked"
333-
aria-label="Global"
334-
ouiaId="IconNav"
335-
>
329+
<Nav onSelect={onNavSelect} variant="docked" aria-label="Global" ouiaId="IconNav">
336330
<NavList>
337331
<NavItem
338332
key="nav-icon-link1"
@@ -354,6 +348,7 @@ export const CompassDockDemo: React.FunctionComponent = () => {
354348
icon={<RhUiFolderIcon />}
355349
hasExpandableIcon={!isMobile}
356350
buttonProps={{ ref: navItem5Ref, 'aria-label': 'Folder' }}
351+
onExpand={onToggleNavGroup}
357352
>
358353
<NavItem
359354
preventDefault

packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ export const NavDockedNav: React.FunctionComponent = () => {
114114
const onNavSelect = (_event: React.FormEvent<HTMLInputElement>, selectedItem: NavOnSelectProps) => {
115115
typeof selectedItem.itemId === 'number' && setActiveItem(selectedItem.itemId);
116116

117-
setIsNavGroupExpanded(false);
118117
setIsDockExpandableExpanded(false);
119118
setIsDockTextExpanded(false);
120119
setIsDockExpanded(false);
@@ -271,11 +270,12 @@ export const NavDockedNav: React.FunctionComponent = () => {
271270
}
272271
};
273272

274-
const onToggleNavGroup = (
275-
_event: React.MouseEvent<HTMLButtonElement>,
276-
result: { groupId: number | string; isExpanded: boolean }
277-
) => {
278-
setIsNavGroupExpanded(result.isExpanded);
273+
const onToggleNavGroup = (_event: React.MouseEvent<HTMLButtonElement>, isExpanded: boolean) => {
274+
if (!isDockExpandableExpanded) {
275+
setIsNavGroupExpanded(true);
276+
} else {
277+
setIsNavGroupExpanded(isExpanded);
278+
}
279279

280280
if (!isMobile) {
281281
if (!isDockExpandableExpanded && !isDockTextExpanded) {
@@ -350,7 +350,7 @@ export const NavDockedNav: React.FunctionComponent = () => {
350350
<Toolbar isVertical>
351351
<ToolbarContent>
352352
<ToolbarItem>
353-
<Nav onSelect={onNavSelect} onToggle={onToggleNavGroup} variant="docked" aria-label="Global">
353+
<Nav onSelect={onNavSelect} variant="docked" aria-label="Global">
354354
<NavList>
355355
<NavItem
356356
preventDefault
@@ -371,6 +371,7 @@ export const NavDockedNav: React.FunctionComponent = () => {
371371
icon={<RhUiFolderIcon />}
372372
hasExpandableIcon={!isMobile}
373373
buttonProps={{ ref: navItem5Ref, 'aria-label': 'Folder' }}
374+
onExpand={onToggleNavGroup}
374375
>
375376
<NavItem
376377
preventDefault

0 commit comments

Comments
 (0)