Skip to content

Commit 584cf2e

Browse files
authored
fix(clipboard-copy): added rtl support (#9629)
* fix(clipboard-copy): added rtl support * chore: spread dir attr, add missing icon wrapper * chore: update snaps
1 parent 1450137 commit 584cf2e

5 files changed

Lines changed: 26 additions & 16 deletions

File tree

packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ class ClipboardCopy extends React.Component<ClipboardCopyProps, ClipboardCopySta
242242
value={this.state.text as string | number}
243243
id={`text-input-${id}`}
244244
aria-label={textAriaLabel}
245+
{...(isCode && { dir: 'ltr' })}
245246
/>
246247
<ClipboardCopyButton
247248
exitDelay={exitDelay}

packages/react-core/src/components/ClipboardCopy/ClipboardCopyExpanded.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ClipboardCopyExpanded extends React.Component<ClipboardCopyExpandedProps>
3636
contentEditable={!isReadOnly}
3737
{...props}
3838
>
39-
{isCode ? <pre>{children}</pre> : children}
39+
{isCode ? <pre dir="ltr">{children}</pre> : children}
4040
</div>
4141
);
4242
}

packages/react-core/src/components/ClipboardCopy/ClipboardCopyToggle.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import * as React from 'react';
2+
import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy';
3+
import { css } from '@patternfly/react-styles';
24
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
3-
import AngleDownIcon from '@patternfly/react-icons/dist/esm/icons/angle-down-icon';
45
import { Button } from '../Button';
56

67
export interface ClipboardCopyToggleProps
@@ -31,7 +32,9 @@ export const ClipboardCopyToggle: React.FunctionComponent<ClipboardCopyTogglePro
3132
aria-expanded={isExpanded}
3233
{...props}
3334
>
34-
{isExpanded ? <AngleDownIcon aria-hidden="true" /> : <AngleRightIcon aria-hidden="true" />}
35+
<div className={css(styles.clipboardCopyToggleIcon)}>
36+
<AngleRightIcon aria-hidden="true" />
37+
</div>
3538
</Button>
3639
);
3740
ClipboardCopyToggle.displayName = 'ClipboardCopyToggle';

packages/react-core/src/components/ClipboardCopy/__tests__/__snapshots__/ClipboardCopyExpanded.test.tsx.snap

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ exports[`expanded code content render 1`] = `
77
contenteditable="true"
88
id="id-1"
99
>
10-
<pre>
10+
<pre
11+
dir="ltr"
12+
>
1113
{
1214
"name": "@patternfly/react-core",
1315
"version": "1.33.2"

packages/react-core/src/components/ClipboardCopy/__tests__/__snapshots__/ClipboardCopyToggle.test.tsx.snap

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,23 @@ exports[`ClipboardCopyToggle toggle button render 1`] = `
1515
id="my-id"
1616
type="button"
1717
>
18-
<svg
19-
aria-hidden="true"
20-
class="pf-v5-svg"
21-
fill="currentColor"
22-
height="1em"
23-
role="img"
24-
viewBox="0 0 256 512"
25-
width="1em"
18+
<div
19+
class="pf-v5-c-clipboard-copy__toggle-icon"
2620
>
27-
<path
28-
d="M224.3 273l-136 136c-9.4 9.4-24.6 9.4-33.9 0l-22.6-22.6c-9.4-9.4-9.4-24.6 0-33.9l96.4-96.4-96.4-96.4c-9.4-9.4-9.4-24.6 0-33.9L54.3 103c9.4-9.4 24.6-9.4 33.9 0l136 136c9.5 9.4 9.5 24.6.1 34z"
29-
/>
30-
</svg>
21+
<svg
22+
aria-hidden="true"
23+
class="pf-v5-svg"
24+
fill="currentColor"
25+
height="1em"
26+
role="img"
27+
viewBox="0 0 256 512"
28+
width="1em"
29+
>
30+
<path
31+
d="M224.3 273l-136 136c-9.4 9.4-24.6 9.4-33.9 0l-22.6-22.6c-9.4-9.4-9.4-24.6 0-33.9l96.4-96.4-96.4-96.4c-9.4-9.4-9.4-24.6 0-33.9L54.3 103c9.4-9.4 24.6-9.4 33.9 0l136 136c9.5 9.4 9.5 24.6.1 34z"
32+
/>
33+
</svg>
34+
</div>
3135
</button>
3236
</DocumentFragment>
3337
`;

0 commit comments

Comments
 (0)