feat(CC-batch-6): review-athon round 1 followup

Author: mattnolting

packages/code-connect/components/JumpLinks/JumplinkHorizontal.figma.tsx

@@ -1,6 +1,7 @@
 import figma from '@figma/code-connect';
 import { JumpLinksItem } from '@patternfly/react-core';
 
+// TODO: DESIGN: FIGMA: Remove icons, help popup, and close button
 // Documentation for JumpLinks can be found at https://www.patternfly.org/components/jump-links
 
 figma.connect(
@@ -12,14 +13,11 @@ figma.connect(
       tabText: figma.string('Tab Text'),
 
       // enum
-      isActive: figma.enum('State', { Selected: true }),
-
-      children: figma.children('*')
+      isActive: figma.enum('State', { Selected: true })
     },
     example: (props) => (
       <JumpLinksItem href="#" isActive={props.isActive}>
         {props.tabText}
-        {props.children}
       </JumpLinksItem>
     )
   }

packages/code-connect/components/JumpLinks/JumplinksHorizontal.figma.tsx

@@ -10,7 +10,7 @@ figma.connect(
     props: {
       // boolean
       label: figma.boolean('Show label', {
-        true: 'Horizontal jump links',
+        true: 'Jump to section',
         false: undefined
       }),
 

packages/code-connect/components/JumpLinks/JumplinksVertical.figma.tsx

@@ -10,7 +10,7 @@ figma.connect(
     props: {
       // boolean
       label: figma.boolean('Show Label', {
-        true: 'Vertical jump links',
+        true: 'Jump to section',
         false: undefined
       }),
 

packages/code-connect/components/Label/LabelGroups.figma.tsx

@@ -12,7 +12,7 @@ figma.connect(
       labelGroupName: figma.string('Label group name'),
 
       // boolean
-      hasCollapsedLabels: figma.boolean('Has collapsed labels', {
+      numLabels: figma.boolean('Has collapsed labels', {
         true: 4,
         false: undefined
       }),
@@ -42,7 +42,7 @@ figma.connect(
         categoryName="Group label"
         isClosable
         isEditable
-        numLabels={props.hasCollapsedLabels}
+        numLabels={props.numLabels}
         onClick={() => {}}
       >
         {props.children}

packages/code-connect/components/Label/LabelInGroup.figma.tsx

@@ -1,8 +1,8 @@
 import figma from '@figma/code-connect';
 import { Label } from '@patternfly/react-core';
 
-// TODO: FIGMA: Reconfigure how numlabels is set. Currently, the text string "more" is not customizable
-// TODO: FIGMA: Label group should contain label components
+// TODO: DESIGN: Reconfigure how numlabels is set. Currently, the text string "more" is not customizable
+// TODO: DESIGN: Label group should contain label components
 
 // NOTE: "Label overflow" doesn't appear to be necessary
 // Documentation for Label can be found at https://www.patternfly.org/components/label-group

packages/code-connect/components/Label/LabelNonStatus.figma.tsx

@@ -12,51 +12,38 @@ figma.connect(
       labelText: figma.string('Text'),
 
       // boolean
-      isEditable: figma.boolean('Is Editable'),
-      onEditCancel: figma.boolean('Is Editable', {
-        true: `{() => {}}`,
-        false: undefined
-      }),
-      onEditComplete: figma.boolean('Is Editable', {
-        true: `{() => {}}`,
-        false: undefined
-      }),
-      editableProps: figma.boolean('Is Editable', {
+      isEditable: figma.boolean('Is Editable', {
         true: {
-          'aria-label': 'Editable label props',
-          id: 'editable-label'
+          isEditable: true,
+          onEditCancel: () => {}, // Callback when an editable label cancels an edit.
+          onEditComplete: () => {}, // Callback when an editable label completes an edit.
+          editableProps: {
+            'aria-label': `Editable label with text`,
+            id: 'editable-label'
+          }
         },
         false: undefined
       }),
 
       // enum
-      isCompact: figma.enum('Type', { Compact: true }),
+      isCompact: figma.enum('Size', { Compact: true }),
       color: figma.enum('Color', {
         Red: 'red',
         Orange: 'orange',
         'Orange Red': 'orangered',
         Green: 'green',
         Blue: 'blue',
         Purple: 'purple',
-        Grey: 'grey'
-      }),
-      variant: figma.enum('Type', {
-        Filled: 'filled',
-        Outlined: 'outline'
+        Grey: 'grey',
+        Teal: 'teal',
+        Yellow: 'yellow'
       }),
+      variant: figma.enum('Type', { Outlined: 'outline' }),
 
       children: figma.children('*')
     },
     example: (props) => (
-      <Label
-        isCompact={props.isCompact}
-        isEditable={props.isEditable}
-        onEditCancel={props.onEditCancel}
-        onEditComplete={props.onEditComplete}
-        editableProps={props.editableProps}
-        color={props.color}
-        variant={props.variant}
-      >
+      <Label isCompact={props.isCompact} isEditable={props.isEditable} color={props.color} variant={props.variant}>
         {props.children}
         {props.labelText}
       </Label>

packages/code-connect/components/Label/LabelStatus.figma.tsx

@@ -10,18 +10,14 @@ figma.connect(
     props: {
       // string
       text: figma.string('Text'),
-      children: figma.children('*'),
+      isCompact: figma.enum('Size', { Compact: true }),
 
       // enum
-      isCompact: figma.enum('Size', { Compact: true }),
-      variant: figma.enum('Type', {
-        Filled: 'filled',
-        Outlined: 'outline'
-      }),
+      variant: figma.enum('Type', { Outlined: 'outline' }),
       status: figma.enum('Status', {
-        Danger: 'danger',
-        Warning: 'warning',
         Success: 'success',
+        Warning: 'warning',
+        Danger: 'danger',
         Info: 'info',
         Custom: 'custom'
       })

packages/code-connect/components/Masthead/Masthead.figma.tsx

@@ -2,9 +2,9 @@ import figma from '@figma/code-connect';
 import { Button, Masthead, MastheadContent, MastheadMain, MastheadToggle } from '@patternfly/react-core';
 import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
 
-// TODO: FIGMA: Create masthead main section MastheadMain MastheadContent
-// TODO: FIGMA: Move Context Switcher, Horizontal Nav, etc to MastheadContent
-// TODO: FIGMA: Create necessary wrappers for MastheadToggle, MastheadBrand, MastheadContent
+// TODO: DESIGN: Create masthead main section MastheadMain MastheadContent
+// TODO: DESIGN: Move Context Switcher, Horizontal Nav, etc to MastheadContent
+// TODO: DESIGN: Create necessary wrappers for MastheadToggle, MastheadBrand, MastheadContent
 // Documentation for Masthead can be found at https://www.patternfly.org/components/masthead
 
 figma.connect(

packages/code-connect/components/Modal/AlertModal.figma.tsx

@@ -2,17 +2,17 @@ import figma from '@figma/code-connect';
 import { Button, Modal, ModalBody, ModalFooter, ModalHeader, Popover } from '@patternfly/react-core';
 import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
 
-// TODO: FIGMA: Add Modal Body component to Modal
-// TODO: FIGMA: Add Modal Footer component to Modal
-// TODO: FIGMA: Add Modal Header component to Modal
+// TODO: DESIGN: Add Modal Body component to Modal
+// TODO: DESIGN: Add Modal Footer component to Modal
+// TODO: DESIGN: Add Modal Header component to Modal
 // Documentation for Modal can be found at https://www.patternfly.org/components/modal
 
 figma.connect(
   Modal,
   'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=2940-18403',
   {
     props: {
-      // TODO: FIGMA: Create ModalHeader component
+      // TODO: DESIGN: Create ModalHeader component
       // hasHelpIcon: figma.boolean('Help icon', {
       //   true: (
       //     <Popover

packages/code-connect/components/Modal/BasicModal.figma.tsx

@@ -2,17 +2,17 @@ import figma from '@figma/code-connect';
 import { Button, Modal, ModalBody, ModalFooter, ModalHeader, Popover } from '@patternfly/react-core';
 import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
 
-// TODO: FIGMA: Add Modal Body component to Modal
-// TODO: FIGMA: Add Modal Footer component to Modal
-// TODO: FIGMA: Add Modal Header component to Modal
+// TODO: DESIGN: Add Modal Body component to Modal
+// TODO: DESIGN: Add Modal Footer component to Modal
+// TODO: DESIGN: Add Modal Header component to Modal
 // Documentation for Modal can be found at https://www.patternfly.org/components/modal
 
 figma.connect(
   Modal,
   'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=2937-158',
   {
     props: {
-      // TODO: FIGMA: Create ModalHeader component
+      // TODO: DESIGN: Create ModalHeader component
       // hasHelpIcon: figma.boolean('Help icon', {
       //   true: (
       //     <Popover