Skip to content

Commit 7b1421c

Browse files
committed
feat(CC-batch-5): review-athon round 1 followup
1 parent 6484d23 commit 7b1421c

7 files changed

Lines changed: 29 additions & 46 deletions

File tree

packages/code-connect/components/EmptyState/EmptyState.figma.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,15 @@ import figma from '@figma/code-connect';
22
import { EmptyState, EmptyStateBody, EmptyStateFooter, EmptyStateActions } from '@patternfly/react-core';
33
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
44

5-
// TODO: FIGMA: Add Empty state footer
6-
// TODO: FIGMA: Consolodate empty state examples
7-
// TODO: FIGMA: Add empty state footer
8-
// TODO: FIGMA: Add empty state actions
9-
// TODO: FIGMA: Add empty state icon
10-
// TODO: FIGMA: Add empty state title
11-
// TODO: FIGMA: Add empty state body
12-
// TODO: FIGMA: Add empty state variant
13-
// TODO: FIGMA: Add empty state status
14-
// TODO: FIGMA: Add empty state isLoading
5+
// TODO: DESIGN: Add Empty state footer
6+
// TODO: DESIGN: Consolodate empty state examples
7+
// TODO: DESIGN: Add empty state footer
8+
// TODO: DESIGN: Add empty state actions
9+
// TODO: DESIGN: Add empty state icon
10+
// TODO: DESIGN: Add empty state title
11+
// TODO: DESIGN: Add empty state body
12+
// TODO: DESIGN: Add empty state variant
13+
// TODO: DESIGN: Add empty state status
1514
// Based on Code Connect's limitations, this component needs to be overhauled. Using the base component approach present in
1615
// other components would significantly reduce complexity.
1716

@@ -44,6 +43,7 @@ figma.connect(
4443
},
4544
example: (props) => (
4645
<EmptyState
46+
// this may need to be updated for accessibility
4747
headingLevel="h4"
4848
icon={<PlusCircleIcon />}
4949
variant={props.variant}

packages/code-connect/components/ExpandableSection/ExandableSectionTruncate.figma.tsx

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,31 @@
11
import figma from '@figma/code-connect';
22
import { ExpandableSection } from '@patternfly/react-core';
33

4-
// TODO: FIGMA: Create toggle component
4+
// TODO: DESIGN: Create toggle component
55
// onToggle={() => {}} // only required if the user wants to be able to have other side effects when opening/closing
66
// isExpanded={() => {}} // only required if the user wants to be able to have other side effects when opening/closing
77

88
// Documentation for ExpandableSection can be found at https://www.patternfly.org/components/expandable-section
99

10-
const toggleContent = `
11-
<div>
12-
<span>You can also use icons </span>
13-
<CheckCircleIcon />
14-
<span> or badges </span>
15-
<Badge isRead={true}>4</Badge>
16-
<span> !</span>
17-
</div>
18-
`;
19-
2010
figma.connect(
2111
ExpandableSection,
2212
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=2769-146',
2313
{
2414
props: {
2515
// enum
2616
isIndented: figma.enum('State', { 'Expanded Indent': true }),
27-
toggleContent: figma.enum('State', { Expanded: toggleContent }),
2817
toggleTextCollapsed: figma.enum('State', { Collapsed: figma.string('Toggle Text More') }),
2918
toggleTextExpanded: figma.enum('State', { Expanded: figma.string('Toggle Text Less') }),
3019

3120
// boolean
3221
expandedContentSectionText: figma.enum('State', {
3322
Default: figma.string('Default Truncate Text'),
3423
Expanded: figma.string('Expanded Truncate Text')
35-
}),
36-
isExpanded: figma.enum('State', { Expanded: true }),
37-
38-
children: figma.children('*')
24+
})
3925
},
4026
example: (props) => (
4127
<ExpandableSection
4228
isIndented={props.isIndented}
43-
toggleContent={props.toggleContent}
4429
toggleTextCollapsed={props.toggleTextCollapsed}
4530
toggleTextExpanded={props.toggleTextExpanded}
4631
variant="truncate"

packages/code-connect/components/ExpandableSection/ExpandableSection.figma.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import figma from '@figma/code-connect';
22
import { ExpandableSection } from '@patternfly/react-core';
33

4-
// TODO: FIGMA: This component needs to be overhauled. Using the base component approach present in
4+
// TODO: DESIGN: This component needs to be overhauled. Using the base component approach present in
55
// other components would significantly reduce complexity.
6-
// TODO: FIGMA: Create toggle component
6+
// TODO: DESIGN: Create toggle component
77
// onToggle={() => {}} // only required if the user wants to be able to have other side effects when opening/closing
88
// isExpanded={() => {}} // only required if the user wants to be able to have other side effects when opening/closing
99

packages/code-connect/components/ExpandableSection/ExpandableSectionDisclosure.figma.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,14 @@ figma.connect(
1818
'Expanded Indent': true,
1919
'Expanded Custom Content': true
2020
}),
21-
isIndented: figma.enum('State', { 'Expanded Indent': true }),
22-
23-
children: figma.children('*')
21+
isIndented: figma.enum('State', { 'Expanded Indent': true })
2422
},
2523
example: (props) => (
2624
// Documentation for ExpandableSection can be found at https://www.patternfly.org/components/expandable-section
2725
<ExpandableSection
2826
isExpanded={props.isExpanded}
2927
isIndented={props.isIndented}
30-
toggleContent={props.children}
28+
onToggle={() => {}}
3129
toggleTextCollapsed={props.toggleTextCollapsed}
3230
toggleTextExpanded={props.toggleTextExpanded}
3331
variant="truncate"

packages/code-connect/components/FileUpload/MultipleFileUpload.figma.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ import {
88
} from '@patternfly/react-core';
99
import UploadIcon from '@patternfly/react-icons/dist/esm/icons/upload-icon';
1010

11-
// TODO: FIGMA: Add status toggle text
12-
// TODO: FIGMA: Add status toggle icon
13-
// TODO: FIGMA: Add text separator
14-
// TODO: FIGMA: Add info text
15-
// TODO: FIGMA: Add status toggle text
16-
// TODO: FIGMA: Add status toggle icon
11+
// TODO: DESIGN: Add status toggle text
12+
// TODO: DESIGN: Add status toggle icon
13+
// TODO: DESIGN: Add text separator
14+
// TODO: DESIGN: Add info text
15+
// TODO: DESIGN: Add status toggle text
16+
// TODO: DESIGN: Add status toggle icon
1717

1818
figma.connect(
1919
FileUpload,

packages/code-connect/components/FileUpload/SimpleFileUpload.figma.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import figma from '@figma/code-connect';
22
import { FileUpload, FileUploadHelperText, HelperText, HelperTextItem } from '@patternfly/react-core';
33

4-
// TODO: FIGMA: Add filename placeholder
5-
// TODO: FIGMA: Add browse button text
6-
// TODO: FIGMA: Add FileUploadHelperText
4+
// TODO: DESIGN: Add filename placeholder
5+
// TODO: DESIGN: Add browse button text
6+
// TODO: DESIGN: Add FileUploadHelperText
77

88
figma.connect(
99
FileUpload,

packages/code-connect/components/Hint/Hint.figma.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ import {
1212
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
1313
import MenuToggle from '@patternfly/react-core/dist/js/components/MenuToggle/MenuToggle';
1414

15-
// TODO: FIGMA: Use dropdown from figma for actions
16-
// TODO: FIGMA: Create hint title
17-
// TODO: FIGMA: Create hint body
18-
// TODO: FIGMA: Create hint footer
15+
// TODO: DESIGN: Use dropdown from figma for actions
16+
// TODO: DESIGN: Create hint title
17+
// TODO: DESIGN: Create hint body
18+
// TODO: DESIGN: Create hint footer
1919

2020
// Note: Figma will not render conditional props within React components.
2121
// This means that the <HintTitle>, <HintBody>, and <HintFooter> tags will not be properly render figma.string()

0 commit comments

Comments
 (0)