Address Eric's feedback

Author: rebeccaalpert

packages/react-core/src/components/Page/__tests__/Page.test.tsx

@@ -529,7 +529,7 @@ describe('Page docked variant', () => {
       </Page>
     );
 
-    const footer = screen.getByText('Custom footer');
+    const footer = screen.getByRole('contentinfo');
     expect(footer).toHaveClass(styles.pageFooter);
     expect(footer.parentElement).toHaveClass(styles.page);
   });

packages/react-core/src/components/Page/__tests__/PageFooter.test.tsx

@@ -4,17 +4,22 @@ import { PageFooter } from '../PageFooter';
 
 test('Renders children', () => {
   render(<PageFooter>Footer content</PageFooter>);
-  expect(screen.getByText('Footer content')).toBeVisible();
+  expect(screen.getByRole('contentinfo')).toBeVisible();
+});
+
+test('Renders without children', () => {
+  render(<PageFooter data-testid="footer" />);
+  expect(screen.getByTestId('footer')).toBeVisible();
 });
 
 test(`Renders with class ${styles.pageFooter} by default`, () => {
   render(<PageFooter>Footer content</PageFooter>);
-  expect(screen.getByText('Footer content')).toHaveClass(styles.pageFooter, { exact: true });
+  expect(screen.getByRole('contentinfo')).toHaveClass(styles.pageFooter, { exact: true });
 });
 
 test('Renders as a footer by default', () => {
   render(<PageFooter>Footer content</PageFooter>);
-  expect(screen.getByText('Footer content').tagName).toBe('FOOTER');
+  expect(screen.getByRole('contentinfo').tagName).toBe('FOOTER');
 });
 
 test('Renders as a custom component when component is passed', () => {
@@ -24,10 +29,10 @@ test('Renders as a custom component when component is passed', () => {
 
 test('Renders with custom classes when className is passed', () => {
   render(<PageFooter className="custom-class">Footer content</PageFooter>);
-  expect(screen.getByText('Footer content')).toHaveClass('custom-class');
+  expect(screen.getByRole('contentinfo')).toHaveClass('custom-class');
 });
 
 test('Renders with spread props', () => {
   render(<PageFooter id="custom-id">Footer content</PageFooter>);
-  expect(screen.getByText('Footer content')).toHaveAttribute('id', 'custom-id');
+  expect(screen.getByRole('contentinfo')).toHaveAttribute('id', 'custom-id');
 });