Skip to content

Commit cbce9d9

Browse files
chore(primary details): Demo updates (#12581)
Edit toolbars and remove old examples. Achieve parity with Core examples. Co-authored-by: Rebecca Alpert <ralpert@redhat.com>
1 parent 4e13e7c commit cbce9d9

7 files changed

Lines changed: 460 additions & 1198 deletions

File tree

packages/react-core/src/demos/PrimaryDetail.md

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Fragment, useState } from 'react';
77
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
88
import RhUiTrashFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-trash-fill-icon';
99
import RhUiCodeIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-code-icon';
10-
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
10+
import RhUiCubesIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-cubes-icon';
1111
import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-check-circle-fill-icon';
1212
import RhUiWarningFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warning-fill-icon';
1313
import RhUiFilterFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-filter-fill-icon';
@@ -35,30 +35,12 @@ import { DashboardWrapper } from '@patternfly/react-core/dist/js/demos/Dashboard
3535

3636
```
3737

38-
### Primary-detail content padding
39-
40-
```ts file="examples/PrimaryDetail/PrimaryDetailContentPadding.tsx" isFullscreen
41-
42-
```
43-
4438
### Primary-detail card view
4539

4640
```ts file="examples/PrimaryDetail/PrimaryDetailCardView.tsx" isFullscreen
4741

4842
```
4943

50-
### Primary-detail simple list in card
51-
52-
```ts file="examples/PrimaryDetail/PrimaryDetailSimpleListInCard.tsx" isFullscreen
53-
54-
```
55-
56-
### Primary-detail data list in card
57-
58-
```ts file="examples/PrimaryDetail/PrimaryDetailDataListInCard.tsx" isFullscreen
59-
60-
```
61-
6244
### Primary-detail inline modifier
6345

6446
```ts file="examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx" isFullscreen

packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailCardView.tsx

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
DrawerContentBody,
1717
DrawerHead,
1818
DrawerPanelContent,
19+
DrawerSection,
1920
Dropdown,
2021
DropdownItem,
2122
DropdownList,
@@ -618,14 +619,19 @@ export const PrimaryDetailCardView: React.FunctionComponent = () => {
618619
<p>This is a demo that showcases Patternfly cards.</p>
619620
</Content>
620621
</PageSection>
621-
<PageSection isFilled padding={{ md: 'padding' }} aria-label="Card filtering toolbar">
622-
<Toolbar id="card-view-data-toolbar-group-types" clearAllFilters={onDelete}>
623-
<ToolbarContent>{toolbarItems}</ToolbarContent>
624-
</Toolbar>
625-
<Divider component="div" />
626-
</PageSection>
627622
<PageSection isFilled padding={{ default: 'noPadding' }} aria-label="Card content area">
628-
<Drawer isExpanded={isDrawerExpanded} className={'pf-m-inline-on-2xl'}>
623+
<Drawer isExpanded={isDrawerExpanded} isInline>
624+
<DrawerSection>
625+
<Toolbar
626+
id="card-view-data-toolbar-group-types"
627+
clearAllFilters={onDelete}
628+
inset={{ default: 'insetLg' }}
629+
style={{ paddingBlockStart: 'var(--pf-t--global--spacer--md)' }}
630+
>
631+
<ToolbarContent alignItems="center">{toolbarItems}</ToolbarContent>
632+
</Toolbar>
633+
<Divider component="div" />
634+
</DrawerSection>
629635
<DrawerContent panelContent={panelContent}>
630636
<DrawerContentBody hasPadding>{drawerContent}</DrawerContentBody>
631637
</DrawerContent>

0 commit comments

Comments
 (0)