feat(BulkSelect): disable Select none option when no rows are selected (#914)

* feat(BulkSelect): disable Select none when no rows are selected

* test(BulkSelect): add unit tests for disabling Select none option

AssistedBy: Cursor

Author: raswonders

packages/module/src/BulkSelect/BulkSelect.test.tsx

@@ -100,4 +100,40 @@ describe('BulkSelect component', () => {
     expect(screen.getByText('Sélectionner la page (5)')).toBeInTheDocument();
     expect(screen.getByText('Tout sélectionner (10)')).toBeInTheDocument();
   });
+
+  test('should disable Select none when nothing is selected', async () => {
+    const user = userEvent.setup();
+    render(
+      <BulkSelect
+        canSelectAll
+        pageCount={5}
+        totalCount={10}
+        selectedCount={0}
+        pageSelected={false}
+        pagePartiallySelected={false}
+        onSelect={() => null}
+      />
+    );
+
+    await user.click(screen.getByLabelText('Bulk select toggle'));
+    expect(screen.getByRole('menuitem', { name: 'Select none (0)' })).toBeDisabled();
+  });
+
+  test('should enable Select none when at least one row is selected', async () => {
+    const user = userEvent.setup();
+    render(
+      <BulkSelect
+        canSelectAll
+        pageCount={5}
+        totalCount={10}
+        selectedCount={1}
+        pageSelected={false}
+        pagePartiallySelected={true}
+        onSelect={() => null}
+      />
+    );
+
+    await user.click(screen.getByLabelText('Bulk select toggle'));
+    expect(screen.getByRole('menuitem', { name: 'Select none (0)' })).not.toBeDisabled();
+  });
 });

packages/module/src/BulkSelect/BulkSelect.tsx

@@ -88,7 +88,12 @@ export const BulkSelect: FC<BulkSelectProps> = ({
   const splitButtonDropdownItems = useMemo(
     () => (
       <>
-        <DropdownItem ouiaId={`${ouiaId}-select-none`} value={BulkSelectValue.none} key={BulkSelectValue.none}>
+        <DropdownItem
+          ouiaId={`${ouiaId}-select-none`}
+          value={BulkSelectValue.none}
+          key={BulkSelectValue.none}
+          isDisabled={selectedCount === 0}
+        >
           {selectNoneLabel}
         </DropdownItem>
         {isDataPaginated && (
@@ -103,7 +108,7 @@ export const BulkSelect: FC<BulkSelectProps> = ({
         )}
       </>
     ),
-    [ isDataPaginated, canSelectAll, ouiaId, selectNoneLabel, selectPageLabel, selectAllLabel, pageCount, totalCount ]
+    [ isDataPaginated, canSelectAll, ouiaId, selectNoneLabel, selectPageLabel, selectAllLabel, pageCount, totalCount, selectedCount ]
   );
 
   const selectedLabelText = selectedLabel(selectedCount);