Deal with the case of `WP_Http::request()` returning before applying `http_api_debug`

[pbiron]

Currently, if an active plugin hooks into pre_http_request and returns a truthy value, then WP_Http::request() will return before applying http_api_debug. As a result, Plugin::capture_request_response() will not be called it's hooked to http_api_debug.

I think we can also hook into pre_http_request and do the capture there, but it will take some investigation to make sure that works correctly (i.e., I'll need to find a "real world" example of something hooking into pre_http_request to short circuit the request).

[pbiron]

I bet @afragen knows of a plugin that hooks into pre_http_request :-)

To paraphrase, Mr Rogers:

Can you say WordPress Beta Tester?
I knew you could.

[afragen]

Seems like whatever plugin does this needs to remove their filter after it fires. Unless the point is to shutdown http requests.

You might look at https://github.com/norcross/airplane-mode

[afragen]

That was actually legacy code in Beta Tester. I bet it's more correct to use http_response.

Nope, it is the correct filter.

[afragen]

And it's not WordPress Beta Tester causing an issue. 😉

[pbiron]

Of course not, it's this plugin not accounting for this case!

I knew about this before releasing 0.1.1, but didn't want to delay release.

[afragen]

Add add_filter( 'pre_http_request', '__return_false', PHP_INT_MAX ); before call to $this->update_check(). Works locally for me after adding in add_filter('pre_http_request', '__return_true' ); in another plugin.

[afragen]

I don't know all the ramifications.

[afragen]

I think the simpler solution is just tell the user there's a plugin conflict.

[pbiron]

I think the solution is for Plugin::update_check() to also hook into pre_http_request, and call Plugin::capture_request_response(). pre_http_request has different parameters than http_api_debug, so probably need to move the "meat" of capture_request_response() into a helper method and have the callbacks for both call the helper.

It probably would also be a good idea for that helper to do some sanity checks on the $response parameter before assuming it's of the correct type.

[afragen]

add_filter( 'pre_http_request', function($result, $args, $url){
			$result = true === $result ? false : $result;
			return $result;
		}, 10, 3 );

Added to update_check() seems to fix this. Added after other hooks in that function.

[afragen]

The above is an example. For the PR I would place in a function so I can remove_filter at end of update_check