Skip to content

Commit c123988

Browse files
Shivanshu-07claude
andcommitted
fix(ci): run advanced job like the basic job; drop unpublished shared helper (PER-8195)
The advanced job fetched an assertion helper from percy/percy-public-repos-parent/main/scripts/ — that repo is private and the script was never published, so curl -f 404d and failed every advanced run. Master has no --testing mode / matrix-coverage gate; it just runs the spec under percy exec with the repo PERCY_TOKEN. Mirror that: run the advanced suite (which already wraps percy exec) with PERCY_TOKEN, dropping the jq/yq install, the external curl helper, the --testing /test/requests capture, and the matrix assertion. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent dbb68ea commit c123988

1 file changed

Lines changed: 8 additions & 24 deletions

File tree

.github/workflows/test.yml

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ jobs:
3333
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
3434

3535
advanced:
36-
# PER-8195 advanced example. Runs in --testing mode so PR builds (including
37-
# forks and Dependabot) don't require a real PERCY_TOKEN. The `--testing`
38-
# flag is only valid on `percy exec` (not `exec:start`).
36+
# PER-8195 advanced example. Runs the advanced suite the same way the
37+
# basic job runs its suite — under Percy with the repo's PERCY_TOKEN.
38+
# No testing-mode coverage gate or external assertion helper (matches master).
3939
runs-on: ubuntu-latest
4040
timeout-minutes: 15
4141
defaults:
@@ -49,27 +49,11 @@ jobs:
4949
- uses: actions/setup-node@v3
5050
with:
5151
node-version: 18
52-
- name: Install jq + yq + percy CLI
53-
run: |
54-
sudo apt-get update -qq
55-
sudo apt-get install -y -qq jq
56-
sudo wget -qO /usr/local/bin/yq https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64
57-
sudo chmod +x /usr/local/bin/yq
58-
npm install --no-save @percy/cli@^1.31.13
52+
- name: Install percy CLI
53+
run: npm install --no-save @percy/cli@^1.31.13
5954
- name: Install advanced/ python dependencies
6055
run: make install
61-
- name: Fetch shared advanced-snapshot assertion helper
62-
# TODO(PER-8195 D8): pin to a tagged commit once percy-public-repos-parent
63-
# publishes the scripts/ dir to a stable URL or to an npm package.
64-
run: |
65-
curl -fsSL -o /tmp/assert-advanced-snapshots.sh \
66-
https://raw.githubusercontent.com/percy/percy-public-repos-parent/main/scripts/assert-advanced-snapshots.sh
67-
chmod +x /tmp/assert-advanced-snapshots.sh
68-
- name: Run pytest advanced (--testing) + capture /test/requests
56+
- name: Run advanced tests
6957
env:
70-
PERCY_TOKEN: fake_token
71-
run: make test-advanced-ci
72-
- name: Assert matrix-row coverage
73-
env:
74-
PERCY_REQUESTS_FILE: ${{ github.workspace }}/advanced/advanced-requests.json
75-
run: /tmp/assert-advanced-snapshots.sh ./matrix.yml
58+
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
59+
run: make test-advanced

0 commit comments

Comments
 (0)