Refactor duplicate error-checking pattern in wasm compile function#6
Merged
Conversation
Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com>
Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com>
Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add changes to address review feedback for wasm-playground merge
Refactor duplicate error-checking pattern in wasm compile function
Feb 7, 2026
Tasty-Kiwi
added a commit
that referenced
this pull request
Feb 7, 2026
* Initial plan * Extract duplicate error-checking pattern into processAlerts helper Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com> * Remove unnecessary format string in processAlerts Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com> * Use errors.New instead of fmt.Errorf for pre-formatted strings Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Tasty-Kiwi <26067386+Tasty-Kiwi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback from #4 to eliminate duplicate error-checking logic in
wasm/wasm.go.Changes
processAlertshelper function - Consolidates logic for checking alerts, detecting errors, formatting messages, and either returning errors or accumulating warningsprocessAlertsafter lexer, parser, and walker stageserrors.Newfor error creation - Avoids potential format specifier issues when wrapping pre-formatted alert stringsBefore/After
Net reduction: ~42 lines
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.