Skip to content

Refactor duplicate error-checking pattern in wasm compile function #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tasty-Kiwi merged 4 commits into from
Feb 7, 2026
Merged

Refactor duplicate error-checking pattern in wasm compile function #6

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43f4e58
Initial plan
Copilot Feb 7, 2026
6099b46
Extract duplicate error-checking pattern into processAlerts helper
Copilot Feb 7, 2026
32e97eb
Remove unnecessary format string in processAlerts
Copilot Feb 7, 2026
3c347d7
Use errors.New instead of fmt.Errorf for pre-formatted strings
Copilot Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 30 additions & 42 deletions wasm/wasm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package wasm

import (
"bufio"
"errors"
"fmt"
"hybroid/alerts"
"hybroid/ast"
Expand Down Expand Up @@ -64,6 +65,29 @@ func formatAlerts(alertsList []alerts.Alert, source string) string {
return sb.String()
}

// processAlerts processes a list of alerts, returning an error if any are errors,
// or accumulating warnings in the provided strings.Builder.
func processAlerts(alertsList []alerts.Alert, source string, warnings *strings.Builder) error {
if len(alertsList) == 0 {
return nil
}

hasError := false
for _, a := range alertsList {
if a.AlertType() == alerts.Error {
hasError = true
break
}
}

msg := formatAlerts(alertsList, source)
if hasError {
return errors.New(msg)
}
warnings.WriteString(msg)
return nil
}

func compile(code string) (string, error) {
var warnings strings.Builder

Expand All @@ -73,39 +97,15 @@ func compile(code string) (string, error) {
return "", err
}

if len(l.GetAlerts()) > 0 {
hasError := false
for _, a := range l.GetAlerts() {
if a.AlertType() == alerts.Error {
hasError = true
break
}
}

msg := formatAlerts(l.GetAlerts(), code)
if hasError {
return "", fmt.Errorf("%s", msg)
}
warnings.WriteString(msg)
if err := processAlerts(l.GetAlerts(), code, &warnings); err != nil {
return "", err
}

p := parser.NewParser(tokensList)
program := p.Parse()

if len(p.GetAlerts()) > 0 {
hasError := false
for _, a := range p.GetAlerts() {
if a.AlertType() == alerts.Error {
hasError = true
break
}
}

msg := formatAlerts(p.GetAlerts(), code)
if hasError {
return "", fmt.Errorf("%s", msg)
}
warnings.WriteString(msg)
if err := processAlerts(p.GetAlerts(), code, &warnings); err != nil {
return "", err
}

walker.SetupLibraryEnvironments()
Expand All @@ -118,20 +118,8 @@ func compile(code string) (string, error) {
w.Walk()
w.PostWalk()

if len(w.GetAlerts()) > 0 {
hasError := false
for _, a := range w.GetAlerts() {
if a.AlertType() == alerts.Error {
hasError = true
break
}
}

msg := formatAlerts(w.GetAlerts(), code)
if hasError {
return "", fmt.Errorf("%s", msg)
}
warnings.WriteString(msg)
if err := processAlerts(w.GetAlerts(), code, &warnings); err != nil {
return "", err
}

gen := generator.NewGenerator()
Expand Down