More PyQt6 aliases

[chrisjbillington]

PyQt6 dropped QApplication.exec_() in favour of exec(), but PySide6 still allows either exec_() or exec().

Earlier PyQt5 versions don't have exec() since they needed to work on Python 2 where exec is a Python keyword.

We should define exec() on PyQt5 if it's not there already, and exec_() on PyQt6, so that all of them work.

I'll leave this issue open to track any other aliases that come up testing labscript programs

@dihm FYI - you might notice labscript programs crashing in PyQt6 due to use of exec_(). Currently changing that to exec() will fix for PyQt6 but break for older PyQt5. Once we add aliases here, either spelling will work for all three Qt libs.

Edit:

• QApplication/QDialog exec/exec() (added in 42fcc9e)

- [ ] QApplication.desktop missing in PySide6 and PyQt6, this is used in lyse. Looks like it was already deprecated in Qt5, so probably we should not add aliases for it and applications should move to whatever the newer thing is that's supported in Qt5 and Qt6 anyway. edit: already fixed by @dihm in lyse

[chrisjbillington]

@dihm Ah, I see you've already changed exec_() to exec() in labscript libs, strictly speaking this will break on some older Qt5 versions, and since anaconda have been glacially slow with Qt library updates, I haven't checked the dates but every time I do they're shockingly recent and I end up thinking we should support the older Qt5 versions.

Presumably we're going to say the newer labscript programs require a newer qtutils though, in which case the alias will be present so if someone upgrades labscript but not Qt5, things will still work.

[dihm]

I'll admit that pinning new versions of qtutils felt a little strange since we aren't requiring folks to move off PyQt5, but these recent changes make it quite a bit more reasonable. As of my simple testing, everything is working as intended with 4.1.3

As for exec changes, it looks to me like PyQt5 has always had exec since it is python 3 only. (at least that's what pythonguis says, I didn't check changelogs). It also seems like PySide6 throws a deprecation warning if exec_ is used, though it works fine.

In any case, I figure if people are updating labscript installations/qtutils, asking them to update Qt minor versions isn't too bad. Even for custom code, the minor name and type changes are pretty easy to fix once and never think about again. And for anything more serious, qtutils papers over it nicely.