From a97ee5be64fb712b30bf994d2706c10a322afbe5 Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Wed, 23 Sep 2026 22:45:34 -0500 Subject: [PATCH 1/3] fix: resolve pre-existing phpcs violations breaking CI on every push Trailing whitespace in language/de/overview.php, and a missing blank line after the namespace declaration in ext.php and textreparser/plugins/article_text.php, have been failing every CI run on main regardless of what a given commit actually changed. Co-Authored-By: Claude Sonnet 5 --- ext.php | 1 + language/de/overview.php | 2 +- textreparser/plugins/article_text.php | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ext.php b/ext.php index 015bcde..3cbbfd9 100644 --- a/ext.php +++ b/ext.php @@ -9,6 +9,7 @@ * See README.md for full acknowledgments and this fork's changes. */ namespace tas2580\wiki; + /** * @ignore */ diff --git a/language/de/overview.php b/language/de/overview.php index cddefdc..7066a2e 100644 --- a/language/de/overview.php +++ b/language/de/overview.php @@ -33,7 +33,7 @@ // $lang = array_merge($lang, array( 'OVERVIEW' => 'Überblick', - + 'ARTICLES' => 'Alle Artikel', 'ARTICLES_HOT' => 'Beliebte Artikel', 'ARTICLES_LATEST' => 'Neuste Artikel', diff --git a/textreparser/plugins/article_text.php b/textreparser/plugins/article_text.php index ee923a5..ec7ae30 100644 --- a/textreparser/plugins/article_text.php +++ b/textreparser/plugins/article_text.php @@ -8,6 +8,7 @@ * */ namespace tas2580\wiki\textreparser\plugins; + class article_text extends \phpbb\textreparser\row_based_plugin { /** From 840735f64580c1b80cc266416f8c45f08c4d8f16 Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Wed, 23 Sep 2026 22:52:15 -0500 Subject: [PATCH 2/3] fix: remove phpunit.xml.dist testsuite pointing at a nonexistent directory phpunit.xml.dist declares an "Extension Functional Tests" testsuite covering ./tests/functional/, but that directory has never existed in this extension - only tests/migrations/ does. The shared CI workflow's RUN_FUNCTIONAL_TESTS: 0 only adds --exclude-group functional, which filters annotated tests but still requires every declared to exist, so PHPUnit fails immediately with "Test directory ... not found" before any test runs, on every DB/PHP matrix job. Co-Authored-By: Claude Sonnet 5 --- phpunit.xml.dist | 4 ---- 1 file changed, 4 deletions(-) diff --git a/phpunit.xml.dist b/phpunit.xml.dist index 3851877..67ba99f 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -14,10 +14,6 @@ ./tests - ./tests/functional - - - ./tests/functional/ From 567125f25329972aaedf24ed4abd502341b62761 Mon Sep 17 00:00:00 2001 From: William Jacoby Date: Wed, 23 Sep 2026 22:57:48 -0500 Subject: [PATCH 3/3] fix: add tests/functional/ so the shared CI workflow's config generation succeeds The reusable test-framework workflow generates each DB matrix job's phpunit config by copying phpBB core's own .github/phpunit-*-github.xml template, which always declares a "phpBB Functional Tests" testsuite pointing at ../tests/functional. RUN_FUNCTIONAL_TESTS: 0 only adds --exclude-group functional (a test-group filter), it does not skip declaring that directory, so PHPUnit still requires it to exist before any test runs. Confirmed by reproducing the workflow's exact sed-based config generation locally and tracing the "Test directory ... not found" error to this. Other phpbbmodders extensions without functional tests instead disable the entire DB matrix (RUN_MYSQL_JOBS: 0, etc.), but this extension has a real DB-backed migration test (tests/migrations/database/ add_article_description_test.php) worth actually running, so keeping the DB matrix enabled and adding this empty placeholder directory preserves that coverage instead of losing it. Co-Authored-By: Claude Sonnet 5 --- tests/functional/.gitkeep | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/functional/.gitkeep diff --git a/tests/functional/.gitkeep b/tests/functional/.gitkeep new file mode 100644 index 0000000..e69de29