Skip to content

Feature: Full-text search across virtualized diffs/code #846

Description

@emma-sg

Prerequisites

Proposal

I'd love to be able to do simple substring search across an entire diff (e.g. in DiffsHub). This would mean a bit of extra UI, and maybe binding to cmd/ctrl+f. I'm not totally sure if there'd need to be any particular affordances made to efficiently search though a large volume of text, but... that seems like it's probably a solved problem at this point in computer science.

Motivation and context

Currently, as scrolling is virtualized, the browser's native page search is only able to find content that's within the rendered window, which for large diffs can be a vanishingly small amount of what's available. GitHub themselves has this implemented for their Actions logs, but it's a pain elsewhere. I usually end up using Zed's git diff view for this, but it doesn't show comments from GitHub, so I end up having to go back and forth and keep scroll position synced manually and it's a whole pain.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions