You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current ProjectFaviconResolver already handles well-known favicon paths and explicit t3.json / <link rel="icon"> declarations, but it misses two common icon sources:
PWA manifest.json / site.webmanifest files that declare icons arrays.
Projects that place icon files in asset directories without explicitly referencing them in source files (e.g. images/icon.png, assets/logo.svg, static/favicon.ico).
Proposed change
Parse manifest.json, public/manifest.json, site.webmanifest and public/site.webmanifest for icon src entries, preferring the largest declared icon size.
Add a directory-scan fallback over common asset folders (public, app, src, src/app, assets, static, resources, images, img, media, app-icon, .idea) looking for well-known icon filenames with a priority by name and extension.
Extend the ProjectFaviconResolutionError operations to cover read-manifest and scan-directory.
Add unit tests for both new detection paths.
This improves icon coverage for PWAs, monorepos and projects that keep icons under arbitrary asset folders.
This discussion was converted from issue #4636 on August 15, 2026 10:04.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
The current ProjectFaviconResolver already handles well-known favicon paths and explicit
t3.json/<link rel="icon">declarations, but it misses two common icon sources:manifest.json/site.webmanifestfiles that declareiconsarrays.images/icon.png,assets/logo.svg,static/favicon.ico).Proposed change
manifest.json,public/manifest.json,site.webmanifestandpublic/site.webmanifestfor iconsrcentries, preferring the largest declared icon size.public,app,src,src/app,assets,static,resources,images,img,media,app-icon,.idea) looking for well-known icon filenames with a priority by name and extension.ProjectFaviconResolutionErroroperations to coverread-manifestandscan-directory.This improves icon coverage for PWAs, monorepos and projects that keep icons under arbitrary asset folders.
All reactions