From acafdd1853eedc14b588587b201f1994e88fc7bc Mon Sep 17 00:00:00 2001 From: Narutama Aurum Date: Tue, 9 Jun 2026 21:57:59 +0800 Subject: [PATCH 1/2] fix: remove leftover console.log(error) in lib/user-data.ts (issue #274) --- lib/user-data.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/user-data.ts b/lib/user-data.ts index 594685b2..ce433323 100644 --- a/lib/user-data.ts +++ b/lib/user-data.ts @@ -9,8 +9,7 @@ export const getUserById = async (id: string) => { } }); return user; - } catch (error) { - console.log(error); + } catch { return null; } }; @@ -21,8 +20,7 @@ export const getUserByEmail = async (email: string) => { where: { email } }); return user; - } catch (error) { - console.log(error); + } catch { return null; } }; @@ -35,8 +33,7 @@ export const getAccountByUserId = async (userId: string) => { } }); return account; - } catch (error) { - console.log(error); + } catch { return null; } }; From 15dcc9c3bfde82b75414b9dd65a54d0e7a3f06ef Mon Sep 17 00:00:00 2001 From: Narutama Aurum Date: Tue, 9 Jun 2026 23:55:37 +0800 Subject: [PATCH 2/2] fix: improve error handling in user-data helpers - Replace bare catch blocks with proper error capture and structured logging - Log errors with function name and query parameters for observability - Rethrow errors so callers can differentiate DB failures from not-found results - Follow existing structured logging pattern from lib/api-utils.ts Addresses CodeRabbit review on PR #488 --- lib/user-data.ts | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/lib/user-data.ts b/lib/user-data.ts index ce433323..c5afd3ac 100644 --- a/lib/user-data.ts +++ b/lib/user-data.ts @@ -1,5 +1,18 @@ import { db } from "@/lib/db"; +const logError = (functionName: string, params: Record, error: unknown) => { + console.error( + JSON.stringify({ + timestamp: new Date().toISOString(), + level: "error", + context: functionName, + params, + error: error instanceof Error ? error.message : "Unknown error", + stack: error instanceof Error ? error.stack : undefined, + }) + ); +}; + export const getUserById = async (id: string) => { try { const user = await db.user.findUnique({ @@ -9,8 +22,9 @@ export const getUserById = async (id: string) => { } }); return user; - } catch { - return null; + } catch (err) { + logError("getUserById", { id }, err); + throw err; } }; @@ -20,8 +34,9 @@ export const getUserByEmail = async (email: string) => { where: { email } }); return user; - } catch { - return null; + } catch (err) { + logError("getUserByEmail", { email }, err); + throw err; } }; @@ -33,7 +48,8 @@ export const getAccountByUserId = async (userId: string) => { } }); return account; - } catch { - return null; + } catch (err) { + logError("getAccountByUserId", { userId }, err); + throw err; } };