[New Check]: Excessive prefix in CONFIG_CHECK options

[rzsn]

Is there an existing such new check request for this?

• I have searched the existing issues

Explain

followup from https://bugs.gentoo.org/968664

When I was updating my machine today, the following message was shown:

 * Messages for package media-sound/alsa-tools-1.2.15-r1:

 *   CONFIG_CONFIG_SND_HDA_RECONFIG:     is not set when it should be.
 * Please check to make sure these options are set correctly.
 * Failure to do so may cause unexpected problems.

Looking further into this on other packages, the CONFIG_CHECK setting expects a bare kernel config option, without the CONFIG_ prefix explicitly stated, as the building system will prefix the stated values with the CONFIG_ at the time of checking them against the kernel config file.

Therefore the new check would be testing the contents of the CONFIG_CHECK variable, and if any of the values start with excessive CONFIG_ prefix the ebuild shall be rejected/reported as malformed.

Examples

I have discovered (at least) two violations, via:

/var/db/repos/gentoo $ grep -r -e CONFIG_CHECK= | grep '~CONFIG'

dev-libs/libugpio/libugpio-0.0.7-r1.ebuild:CONFIG_CHECK="~CONFIG_GPIO_SYSFS"
media-sound/alsa-tools/alsa-tools-1.2.15-r1.ebuild:CONFIG_CHECK="~CONFIG_SND_HDA_RECONFIG"

(already patched as per linked Gentoo bug)

Output message

Kernel config options - excessive CONFIG_ prefix found in option name

Documentation

The kernel configuration options shall be stated in form that is seen eg. in menuconfig, without the CONFIG_ prefix that is present in the kernel configuration file.

Result level

error