From b4047be35143afd0c23e5f9e60d4ca388f759e80 Mon Sep 17 00:00:00 2001 From: cfranklin <579516+chris-franklin@users.noreply.github.com> Date: Fri, 10 Jul 2026 17:35:08 +0100 Subject: [PATCH 1/5] Add __TEST_ARGS__ to go_test test_cmd --- build_defs/go.build_defs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build_defs/go.build_defs b/build_defs/go.build_defs index 59706f2..0311386 100644 --- a/build_defs/go.build_defs +++ b/build_defs/go.build_defs @@ -879,7 +879,7 @@ def go_test(name:str, srcs:list, resources:list=None, data:list|dict=None, deps: cmds, tools = _go_binary_cmds(name, static=static, definitions=definitions, gcov=cgo, test=True) - test_cmd = f'$TEST {flags} 2>&1 | tee $TMP_DIR/test.results' + test_cmd = f'$TEST {flags} __TEST_ARGS__ 2>&1 | tee $TMP_DIR/test.results' worker_cmd = f'$(worker {worker})' if worker else "" if worker_cmd: test_cmd = f'{worker_cmd} && {test_cmd} ' From 2cd2885d99b0dae875cb86b73a103641edcc19aa Mon Sep 17 00:00:00 2001 From: cfranklin <579516+chris-franklin@users.noreply.github.com> Date: Fri, 17 Jul 2026 13:18:57 +0100 Subject: [PATCH 2/5] Set test_cmd_args_placeholder and update version and changelog --- ChangeLog | 4 ++++ VERSION | 2 +- build_defs/go.build_defs | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index b1b0625..a16f133 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Version 1.32.0 +-------------- + * Allow passing command-line arguments to go_test targets + Version 1.31.1 -------------- * Fix bug in 1.31.0 where the plugin was still referencing the last version of `please_go` diff --git a/VERSION b/VERSION index 6bae540..359c410 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.31.1 +1.32.0 diff --git a/build_defs/go.build_defs b/build_defs/go.build_defs index 0311386..d565ac7 100644 --- a/build_defs/go.build_defs +++ b/build_defs/go.build_defs @@ -943,6 +943,7 @@ def go_test(name:str, srcs:list, resources:list=None, data:list|dict=None, deps: pre_build = _collect_linker_flags(static, definitions), env = env, provides = provides, + test_cmd_args_placeholder = "__TEST_ARGS__", ) From 0feb636c929be0c78870a410ba47e6afe0ddc950 Mon Sep 17 00:00:00 2001 From: cfranklin <579516+chris-franklin@users.noreply.github.com> Date: Fri, 17 Jul 2026 14:00:39 +0100 Subject: [PATCH 3/5] Update required please version --- .plzconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.plzconfig b/.plzconfig index 80d8842..576e371 100644 --- a/.plzconfig +++ b/.plzconfig @@ -1,5 +1,5 @@ [Please] -Version = >=17.21.0 +Version = >=17.31.0 [build] hashcheckers = sha256 From 366087fb437ebeff4e1a24b11c01bc86e7597f5a Mon Sep 17 00:00:00 2001 From: cfranklin <579516+chris-franklin@users.noreply.github.com> Date: Fri, 17 Jul 2026 14:10:38 +0100 Subject: [PATCH 4/5] Put PR number in release notes --- ChangeLog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index a16f133..b1c71eb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,6 @@ Version 1.32.0 -------------- - * Allow passing command-line arguments to go_test targets + * Allow passing command-line arguments to go_test targets (#368) Version 1.31.1 -------------- From c041331e6e5cb1530e37724b328ff204ab8231fd Mon Sep 17 00:00:00 2001 From: cfranklin <579516+chris-franklin@users.noreply.github.com> Date: Tue, 21 Jul 2026 14:08:19 +0100 Subject: [PATCH 5/5] Update required please version for e2e plugin --- .plzconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.plzconfig b/.plzconfig index 576e371..19800fb 100644 --- a/.plzconfig +++ b/.plzconfig @@ -20,7 +20,7 @@ Target = //plugins:cc [Plugin "e2e"] Target = //plugins:e2e -PleaseVersion = 17.21.0 +PleaseVersion = 17.31.0 [PluginDefinition] Name = go