Small refactor

Author: AdrienClairembault

tests/Front/ConfigFormTest.php

@@ -67,35 +67,41 @@ public function testTabHasContentExistOnConfigPage(): void
     public function testCanDisableQuestionTypeIpConfig(): void
     {
         // Arrange: enable config
+        $manager = $this->getConfigManager();
         Config::setConfigurationValues('advancedforms', [
             ConfigManager::CONFIG_ENABLE_QUESTION_TYPE_IP => 1,
         ]);
-        $this->assertTrue($this->getConfigManager()->getConfig()->isIpAddressQuestionTypeEnabled());
+        $this->assertTrue($manager->getConfig()->isIpAddressQuestionTypeEnabled());
 
         // Act: submit config form
         $this->post("/front/config.form.php", [
             'config_context' => 'advancedforms',
             'update' => 1,
             ConfigManager::CONFIG_ENABLE_QUESTION_TYPE_IP => 0,
         ]);
-        $this->assertFalse($this->getConfigManager()->getConfig()->isIpAddressQuestionTypeEnabled());
+
+        // Assert: config should now be disabled
+        $this->assertFalse($manager->getConfig()->isIpAddressQuestionTypeEnabled());
     }
 
     public function testCanEnableQuestionTypeIpConfig(): void
     {
         // Arrange: disable config
+        $manager = $this->getConfigManager();
         Config::setConfigurationValues('advancedforms', [
             ConfigManager::CONFIG_ENABLE_QUESTION_TYPE_IP => 0,
         ]);
-        $this->assertFalse($this->getConfigManager()->getConfig()->isIpAddressQuestionTypeEnabled());
+        $this->assertFalse($manager->getConfig()->isIpAddressQuestionTypeEnabled());
 
         // Act: submit config form
         $this->post("/front/config.form.php", [
             'config_context' => 'advancedforms',
             'update' => 1,
             ConfigManager::CONFIG_ENABLE_QUESTION_TYPE_IP => 1,
         ]);
-        $this->assertTrue($this->getConfigManager()->getConfig()->isIpAddressQuestionTypeEnabled());
+
+        // Assert: config should now be enabled
+        $this->assertTrue($manager->getConfig()->isIpAddressQuestionTypeEnabled());
     }
 
     private function getConfigManager(): ConfigManager