Google Image Search Review

[pmalviya]

My app is complete, so please provide review comments. cc/@thecodepath /@codepathreview

[codepathreview]

👍 excellent work, Poorva! A few notes after checking out the code:

• Great work on packaging the code correctly
• Good use of SearchFilter object
• Consider using Parcelable over Serializable (benefits)
• Good job using the ConnectivityManager to check for network availability and notifying user about failure (consider externalizing it to Util class)
• Great job implementing SearchFiltersDialog fragment for filters.
• Good to see you added Search using the action bar and correctly implemented sharing
• Good to see JSON deserializing logic in the Image object. (Consider adding null checks)

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[codepathreview]

Also, for parcelable make sure you read and write to parcel in the same order.