Skip to content

empty-catch: sdks/typescript/pmxt/server-manager.ts:141 — health-poll errors silently swallowed with no log #947

@realfishsam

Description

@realfishsam

Violation

} catch {
    // Not ready yet
}

Location

sdks/typescript/pmxt/server-manager.ts:141 (inside the server health-wait loop)

Why It Matters

During server startup polling, any unexpected error (DNS failure, fetch API missing, permission denied on the port) is silently treated as "not ready yet" and retried. The only feedback is that ensureServerRunning() eventually times out after maxRetries * retryDelayMs. A debug-level log on each caught error would allow developers to distinguish a slow-starting server from a misconfigured URL or a crashed process — greatly reducing time-to-diagnosis.

Suggested Fix

} catch (err) {
    logger.debug('server-manager: health poll error', { error: String(err) });
}

Found by automated code hygiene audit

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions