fix opinion child markets hardcoding volume24h to 0#108
Closed
mooncitydev wants to merge 2 commits into
Closed
Conversation
Contributor
|
Merged to main in e547864 — changed the distribution strategy from even split to proportional by child volume. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's the problem
child markets (outcomes within categorical/multi-outcome events) always had
volume24hset to0in the Opinion normalizer, even when the parent market was actively traded. this caused downstream consumers that filter onvolume24h > 0(like matching pipelines) to skip these markets entirely — which is why Opinion had near-zero embedding coverage (~0.4%).what changed
instead of hardcoding
volume24h: 0for child markets, we now read the parent'svolume24hand distribute it evenly across all children. this is a pragmatic approximation since the Opinion API only provides volume at the parent level.normalizeMarketsFromEventcomputesparentVolume24h / childCountand passes that into eachnormalizeChildMarketcall. the private method now accepts avolume24hparameter (defaults to0to stay safe for any direct callers).why even distribution?
the Opinion API doesn't expose per-child volume, so we can't be more precise here. splitting evenly is honest and avoids artificially inflating or hiding any specific outcome. it also unblocks the matching pipeline immediately without needing a more complex weighting scheme.
fixes #106
made by mooncitydev