Skip to content

fix opinion child markets hardcoding volume24h to 0 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mooncitydev wants to merge 2 commits into from
Closed

fix opinion child markets hardcoding volume24h to 0 #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1c52ff
fix opinion child markets volume24h by distributing parent volume evenly
mooncitydev Apr 23, 2026
131badc
fix: distribute volume24h proportionally by child volume instead of e…
realfishsam Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/src/exchanges/opinion/normalizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,15 @@ export class OpinionNormalizer implements IExchangeNormalizer<OpinionRawMarket,
const children = raw.childMarkets || [];
const results: UnifiedMarket[] = [];

const parentVolume24h = parseNumStr(raw.volume24h);
const totalChildVolume = children.reduce((sum, c) => sum + parseNumStr(c.volume), 0);

for (const child of children) {
const market = this.normalizeChildMarket(child, raw);
const childVolume = parseNumStr(child.volume);
const childVolume24h = totalChildVolume > 0
? (childVolume / totalChildVolume) * parentVolume24h
: 0;
const market = this.normalizeChildMarket(child, raw, childVolume24h);
if (market) results.push(market);
}

Expand Down Expand Up @@ -267,6 +274,7 @@ export class OpinionNormalizer implements IExchangeNormalizer<OpinionRawMarket,
private normalizeChildMarket(
child: OpinionRawChildMarket,
parent: OpinionRawMarket,
volume24h: number = 0,
): UnifiedMarket | null {
if (!child) return null;

Expand Down Expand Up @@ -300,7 +308,7 @@ export class OpinionNormalizer implements IExchangeNormalizer<OpinionRawMarket,
description: child.rules || '',
outcomes: [yesOutcome, noOutcome],
resolutionDate: new Date(toMillis(child.cutoffAt)),
volume24h: 0, // child markets do not have volume24h
volume24h,
volume: parseNumStr(child.volume),
liquidity: 0,
url: `https://opinion.trade/market/${child.marketId}`,
Expand Down