Skip to content

fix: validate query params in feed-routes instead of unsafe casts #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realfishsam merged 1 commit into from
May 24, 2026
Merged

fix: validate query params in feed-routes instead of unsafe casts #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 35 additions & 21 deletions core/src/server/feed-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ export function createFeedRouter(): Router {
// GET /api/feeds/:feed/fetchTicker?symbol=BTC/USD
router.get('/:feed/fetchTicker', async (req: Request, res: Response, next: NextFunction) => {
try {
const symbol = req.query.symbol as string;
if (!symbol) {
res.status(400).json({ success: false, error: 'Missing required parameter: symbol' });
const symbol = req.query.symbol;
if (typeof symbol !== 'string') {
res.status(400).json({ success: false, error: 'Missing required query parameter: symbol' });
return;
}
const data = await (req as any)._feed.fetchTicker(symbol);
Expand All @@ -46,7 +46,11 @@ export function createFeedRouter(): Router {
// GET /api/feeds/:feed/fetchTickers?symbols=BTC/USD,ETH/USD
router.get('/:feed/fetchTickers', async (req: Request, res: Response, next: NextFunction) => {
try {
const symbolsRaw = req.query.symbols as string | undefined;
const symbolsRaw = req.query.symbols;
if (symbolsRaw !== undefined && typeof symbolsRaw !== 'string') {
res.status(400).json({ success: false, error: 'Invalid query parameter: symbols must be a string' });
return;
}
const symbols = symbolsRaw ? symbolsRaw.split(',').map((s) => s.trim()) : undefined;
const data = await (req as any)._feed.fetchTickers(symbols);
res.json({ success: true, data });
Expand All @@ -56,14 +60,19 @@ export function createFeedRouter(): Router {
// GET /api/feeds/:feed/fetchOHLCV?symbol=BTC/USDT&timeframe=1h&since=...&limit=...
router.get('/:feed/fetchOHLCV', async (req: Request, res: Response, next: NextFunction) => {
try {
const symbol = req.query.symbol as string;
if (!symbol) {
res.status(400).json({ success: false, error: 'Missing required parameter: symbol' });
const symbol = req.query.symbol;
if (typeof symbol !== 'string') {
res.status(400).json({ success: false, error: 'Missing required query parameter: symbol' });
return;
}
const timeframe = req.query.timeframe;
if (timeframe !== undefined && typeof timeframe !== 'string') {
res.status(400).json({ success: false, error: 'Invalid query parameter: timeframe must be a string' });
return;
}
const data = await (req as any)._feed.fetchOHLCV(
symbol,
(req.query.timeframe as string) || '1h',
timeframe || '1h',
req.query.since ? Number(req.query.since) : undefined,
req.query.limit ? Number(req.query.limit) : undefined,
);
Expand All @@ -79,9 +88,9 @@ export function createFeedRouter(): Router {
res.status(501).json({ success: false, error: `Feed '${req.params.feed}' does not support fetchOrderBook` });
return;
}
const symbol = req.query.symbol as string;
if (!symbol) {
res.status(400).json({ success: false, error: 'Missing required parameter: symbol' });
const symbol = req.query.symbol;
if (typeof symbol !== 'string') {
res.status(400).json({ success: false, error: 'Missing required query parameter: symbol' });
return;
}
const data = await feed.fetchOrderBook(symbol, req.query.limit ? Number(req.query.limit) : undefined);
Expand All @@ -97,9 +106,9 @@ export function createFeedRouter(): Router {
res.status(501).json({ success: false, error: `Feed '${req.params.feed}' does not support fetchOracleRound` });
return;
}
const feedName = req.query.feed as string;
if (!feedName) {
res.status(400).json({ success: false, error: 'Missing required parameter: feed' });
const feedName = req.query.feed;
if (typeof feedName !== 'string') {
res.status(400).json({ success: false, error: 'Missing required query parameter: feed' });
return;
}
const data = await feed.fetchOracleRound({ feed: feedName });
Expand All @@ -115,9 +124,9 @@ export function createFeedRouter(): Router {
res.status(501).json({ success: false, error: `Feed '${req.params.feed}' does not support fetchOracleHistory` });
return;
}
const feedName = req.query.feed as string;
if (!feedName) {
res.status(400).json({ success: false, error: 'Missing required parameter: feed' });
const feedName = req.query.feed;
if (typeof feedName !== 'string') {
res.status(400).json({ success: false, error: 'Missing required query parameter: feed' });
return;
}
const data = await feed.fetchOracleHistory({
Expand All @@ -136,16 +145,21 @@ export function createFeedRouter(): Router {
res.status(501).json({ success: false, error: `Feed '${req.params.feed}' does not support fetchHistoricalPrices` });
return;
}
const symbol = req.query.symbol as string;
if (!symbol) {
res.status(400).json({ success: false, error: 'Missing required parameter: symbol' });
const symbol = req.query.symbol;
if (typeof symbol !== 'string') {
res.status(400).json({ success: false, error: 'Missing required query parameter: symbol' });
return;
}
const order = req.query.order;
if (order !== undefined && typeof order !== 'string') {
res.status(400).json({ success: false, error: 'Invalid query parameter: order must be a string' });
return;
}
const data = await feed.fetchHistoricalPrices(symbol, {
fromTimestamp: req.query.fromTimestamp ? Number(req.query.fromTimestamp) : undefined,
untilTimestamp: req.query.untilTimestamp ? Number(req.query.untilTimestamp) : undefined,
maxSize: req.query.maxSize ? Number(req.query.maxSize) : undefined,
order: req.query.order as 'asc' | 'desc' | undefined,
order: order as 'asc' | 'desc' | undefined,
});
res.json({ success: true, data });
} catch (error) { next(error); }
Expand Down
Loading