Skip to content

fix(deps): refresh npm security dependencies#864

Merged
realfishsam merged 4 commits into
mainfrom
fix/security-js-deps
Jun 8, 2026
Merged

fix(deps): refresh npm security dependencies#864
realfishsam merged 4 commits into
mainfrom
fix/security-js-deps

Conversation

@realfishsam

@realfishsam realfishsam commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Refreshes the npm lockfiles to pick up patched versions of vulnerable transitive dependencies.
  • Bumps the core axios range to the latest safe minor in the workspace manifest.

Verification

  • npm audit --json (root) no longer reports axios, @nestjs/core, lodash, path-to-regexp, picomatch, socket.io-parser, or brace-expansion.
  • npm audit --json --workspaces=false (core) no longer reports the targeted packages.

Fixes #193
Fixes #194
Fixes #195
Fixes #196
Fixes #197
Fixes #198
Fixes #199
Fixes #822
Fixes #823
Fixes #825
Fixes #826
Fixes #827

@mintlify

mintlify Bot commented Jun 5, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
PMXT 🟢 Ready View Preview Jun 5, 2026, 12:40 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@realfishsam

Copy link
Copy Markdown
Contributor Author

PR Review: FAIL

What This Does

Refreshes npm security dependencies and lockfiles; intended consumer behavior is unchanged.

Blast Radius

Root/core npm lockfiles and package metadata.
Changed files reviewed: core/package-lock.json, core/package.json, package-lock.json, sdks/python/API_REFERENCE.md, sdks/typescript/API_REFERENCE.md

Consumer Verification

Before (base branch):
Base branch (origin/main) does not include these changes. I reviewed the diff against the base and did not run full live-exchange before/after reproduction in this daily batch.

After (PR branch):
PR branch build FAIL; authenticated local sidecar smoke FAIL using POST /api/mock/fetchMarkets with x-pmxt-access-token, response snippet: skipped because build failed

Test Results

  • Build: FAIL (npm run build --workspace=pmxt-core)
  • Unit tests: FAIL (npm test --workspace=pmxt-core -- --runInBand)
  • Server starts: FAIL
  • E2E smoke: FAIL (POST /api/mock/fetchMarkets; live venue-specific calls were not made)
  • Dependency install: PASS: npm WARN deprecated glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant ...

Findings

  1. Build failed: src/exchanges/limitless/websocket.ts(276,39): error TS2345: Argument of type '"orderbook"' is not assignable to parameter of type 'SubscriptionChannel'.
    src/exchanges/limitless/websocket.ts(279,39): error TS2345: Argument of type '"prices"' is not assignable to parameter of type 'SubscriptionChannel'.
    ../node_modules/ox/tempo/KeyAuthorization.ts(537,3): error TS2322: Type '{ account?: 0x${string} | undefined; isAdmin?: true | undefined; witness?: 0x${string} | undefined; signature: SignatureEnvelope.SignatureEnvelope<bigint, number>; ... 5 more ...; chainId: bigint; }' is not assignable to type 'Signed<bigint, number, 0x${string}>'.
    Type '{ account?: 0x${string} | undefined; isA...
  2. Core Jest tests failed: at Object. (test/normalizers/exchange-normalizers-3.test.ts:19:1)

Test Suites: 7 failed, 1 skipped, 15 passed, 22 of 23 total
Tests: 3 skipped, 451 passed, 454 total
Snapshots: 0 total
Time: 13.127 s
Ran all test suites.
npm ERR! Lifecycle script test failed with error:
npm ERR! Error: command failed
npm ERR! in workspace: pmxt-core@2.17.1
npm ERR! at location: /opt/data/repos/pmxt/core
3. Server/API smoke failed: skipped because build failed

PMXT Pipeline Check

  • Field propagation (3-layer): N/A
  • OpenAPI sync: N/A
  • Financial precision: OK
  • Type safety: OK
  • Auth safety: N/A

Semver Impact

patch -- bug fix/internal compatibility change unless SDK consumers rely on newly added APIs

Risk

The branch was built, core-tested, and authenticated-smoke-tested through the sidecar. Full live-exchange before/after behavior remains unverified for this daily batch; credentialed venue calls and venue API drift should be treated as residual risk unless covered by tests in this PR.

@realfishsam realfishsam merged commit 4889f32 into main Jun 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment