fix: align SDK models with core order fields#872
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
PR Review: PASS (NOT VERIFIED)What This DoesAligns SDK order models/client conversion with core order fields, changing what Python/TypeScript SDK consumers can access on order-shaped responses. Blast RadiusPython and TypeScript SDK model/client shims plus docs/OpenAPI artifacts. Consumer VerificationBefore (base branch): After (PR branch): Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactminor -- bug fix/internal compatibility change unless SDK consumers rely on newly added APIs RiskThe branch was built, core-tested, and authenticated-smoke-tested through the sidecar. Full live-exchange before/after behavior remains unverified for this daily batch; credentialed venue calls and venue API drift should be treated as residual risk unless covered by tests in this PR. |
PR Review Update: NOT VERIFIEDI attempted the requested post-PR verification, but this PR is not merged. Blocking result
Evidence
No approval/label was added; no merge was performed. |
PR Review Update: NOT VERIFIEDFollow-up verification still did not succeed, so I did not merge this PR. Blocking result
EvidenceNo approval/label was added; no merge was performed. |
PR Review Update: VERIFIEDThis PR is now VERIFIED through the consumer path and has no blocking findings remaining. Evidence
Note: Python-specific pytest execution was not used for merge gating in this runner because the local cron environment lacks a committed/generated Proceeding with the user-approved squash merge for this target PR only. |
Covers everything between 2.48.6 and HEAD plus the hosted-trading-mode work on this branch — Added (7 bullets: hosted trading mode end-to-end, Escrow namespace, hosted error hierarchy, 2 e2e drivers, 87 new dispatch + error-mapping tests, feed listing surface), Changed (9 bullets: SDK 2.18.0 version bumps, new model fields, drift parity sweep, dep refreshes), Fixed (12 bullets covering both the hosted-mode bugs caught by the live $5 buy + sell and the unrelated fixes that landed on main since 2.48.6 — #871 #870 #873 #874 #875 #876 #877 #879 #663 #872 + the three this branch adds), Docs (2 bullets).
Summary\n- Add the missing event pagination / filtering fields to both SDK model definitions.\n- Propagate the missing order-building parameters and return fields through the Python and TypeScript SDKs.\n- Replace the remaining raw console error in the TypeScript websocket client with the internal logger.\n\n## Tests\n- python3 -m compileall sdks/python/pmxt\n- npm run build --workspace=sdks/typescript (fails: missing generated module '../generated/src/index.js' in this worktree)\n\nFixes #806\nFixes #807\nFixes #746\nFixes #747\nFixes #748\nFixes #749\nFixes #750