You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Guards the Python SDK market slug cache so markets with slug=None are still cached by market id but no longer create a None key in markets_by_slug.
Blast Radius
Python SDK only: Exchange.load_markets() cache population. No core/server/OpenAPI changes.
Consumer Verification
Before (base branch):
On base, a UnifiedMarket with slug=None would execute self.markets_by_slug[market.slug] = market, creating a None lookup entry. I did not run a Python consumer repro because this runner is missing pytest for the SDK test phase.
After (PR branch):
Patch adds if market.slug: before writing the slug cache. Core build passed and core Jest tests passed; full root verification stopped in the Python SDK phase with /usr/bin/python3: No module named pytest.
Test Results
Build: PASS
Unit tests: CORE PASS (24 suites, 644 tests; root verification then blocked by missing pytest)
Server starts: PASS during root verification
E2E smoke: NOT VERIFIED (Python SDK environment missing pytest)
Findings
No blocking findings.
PMXT Pipeline Check
Field propagation (3-layer): N/A
OpenAPI sync: N/A
Financial precision: N/A
Type safety: OK
Auth safety: N/A
Semver Impact
patch -- Python SDK cache bug fix without API shape change.
Risk
Python SDK runtime behavior was inspected from the diff but not executed end-to-end in this environment because pytest is not installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #156
Test Plan