Skip to content

Commit 4d22144

Browse files
author
Test
committed
fix: handle unchecked return values in HTTP handlers
1 parent 16fb812 commit 4d22144

1 file changed

Lines changed: 21 additions & 9 deletions

File tree

internal/server/server.go

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,9 @@ func (s *Server) handleServices(w http.ResponseWriter, r *http.Request) {
179179

180180
w.Header().Set("Content-Type", "application/json")
181181
w.Header().Set("X-API-Version", APIVersion)
182-
json.NewEncoder(w).Encode(response)
182+
if err := json.NewEncoder(w).Encode(response); err != nil {
183+
log.Printf("Error encoding services response: %v", err)
184+
}
183185
}
184186

185187
func (s *Server) handleServiceByID(w http.ResponseWriter, r *http.Request) {
@@ -219,7 +221,9 @@ func (s *Server) handleServiceByID(w http.ResponseWriter, r *http.Request) {
219221

220222
w.Header().Set("Content-Type", "application/json")
221223
w.Header().Set("X-API-Version", APIVersion)
222-
json.NewEncoder(w).Encode(response)
224+
if err := json.NewEncoder(w).Encode(response); err != nil {
225+
log.Printf("Error encoding service response: %v", err)
226+
}
223227
return
224228
}
225229
}
@@ -253,7 +257,9 @@ func (s *Server) handleSummary(w http.ResponseWriter, r *http.Request) {
253257

254258
w.Header().Set("Content-Type", "application/json")
255259
w.Header().Set("X-API-Version", APIVersion)
256-
json.NewEncoder(w).Encode(response)
260+
if err := json.NewEncoder(w).Encode(response); err != nil {
261+
log.Printf("Error encoding summary response: %v", err)
262+
}
257263
}
258264

259265
func (s *Server) handleNamespaces(w http.ResponseWriter, r *http.Request) {
@@ -300,18 +306,22 @@ func (s *Server) handleNamespaces(w http.ResponseWriter, r *http.Request) {
300306

301307
w.Header().Set("Content-Type", "application/json")
302308
w.Header().Set("X-API-Version", APIVersion)
303-
json.NewEncoder(w).Encode(response)
309+
if err := json.NewEncoder(w).Encode(response); err != nil {
310+
log.Printf("Error encoding namespaces response: %v", err)
311+
}
304312
}
305313

306314
func (s *Server) handleSpec(w http.ResponseWriter, r *http.Request) {
307315
spec := getOpenAPISpec(r)
308316
w.Header().Set("Content-Type", "application/json")
309-
json.NewEncoder(w).Encode(spec)
317+
if err := json.NewEncoder(w).Encode(spec); err != nil {
318+
log.Printf("Error encoding spec response: %v", err)
319+
}
310320
}
311321

312322
func (s *Server) handleHealth(w http.ResponseWriter, r *http.Request) {
313323
w.WriteHeader(http.StatusOK)
314-
fmt.Fprint(w, "OK")
324+
_, _ = fmt.Fprint(w, "OK")
315325
}
316326

317327
func (s *Server) handleReady(w http.ResponseWriter, r *http.Request) {
@@ -321,12 +331,12 @@ func (s *Server) handleReady(w http.ResponseWriter, r *http.Request) {
321331
}
322332

323333
w.WriteHeader(http.StatusOK)
324-
fmt.Fprint(w, "Ready")
334+
_, _ = fmt.Fprint(w, "Ready")
325335
}
326336

327337
func (s *Server) handleIndex(w http.ResponseWriter, r *http.Request) {
328338
w.Header().Set("Content-Type", "text/html; charset=utf-8")
329-
fmt.Fprint(w, getHTMLPage())
339+
_, _ = fmt.Fprint(w, getHTMLPage())
330340
}
331341

332342
func sendError(w http.ResponseWriter, statusCode int, code, message, details string) {
@@ -346,7 +356,9 @@ func sendError(w http.ResponseWriter, statusCode int, code, message, details str
346356
},
347357
}
348358

349-
json.NewEncoder(w).Encode(response)
359+
if err := json.NewEncoder(w).Encode(response); err != nil {
360+
log.Printf("Error encoding error response: %v", err)
361+
}
350362
}
351363

352364
func filterServices(services []k8s.ServiceStatus, filters map[string]string) []k8s.ServiceStatus {

0 commit comments

Comments
 (0)