Incompatibility with BOSH v2

[bgandon]

Hello,

RDPG v0.3.15 and the newer RDPG v0.2.64 are affected by the more strict property scope applied by BOSH v2, as described in cloudfoundry/bosh#1258

Here is the error log when deploying with BOSH v260:

Error 100: Unable to render instance groups for deployment. Errors are:
   - Unable to render jobs for instance group 'rdpgmc'. Errors are:
     - Unable to render templates for job 'rdpgd-manager'. Errors are:
       - Error filling in template 'env' (line 49: Can't find property '["postgresql.port"]')
       - Error filling in template 'pgbouncer.ini' (line 15: Can't find property '["postgresql.port"]')
   - Unable to render jobs for instance group 'rdpgsc1'. Errors are:
     - Unable to render templates for job 'rdpgd-service'. Errors are:
       - Error filling in template 'env' (line 51: Can't find property '["postgresql.port"]')
       - Error filling in template 'haproxy.cfg' (line 13: Can't find property '["haproxy.timeout_connect"]')
       - Error filling in template 'haproxy.cfg.header' (line 6: Can't find property '["haproxy.max_conn"]')
       - Error filling in template 'pgbouncer.ini' (line 18: Can't find property '["postgresql.port"]')
   - Unable to render jobs for instance group 'rdpgsc2'. Errors are:
     - Unable to render templates for job 'rdpgd-service'. Errors are:
       - Error filling in template 'env' (line 51: Can't find property '["postgresql.port"]')
       - Error filling in template 'haproxy.cfg' (line 13: Can't find property '["haproxy.timeout_connect"]')
       - Error filling in template 'haproxy.cfg.header' (line 6: Can't find property '["haproxy.max_conn"]')
       - Error filling in template 'pgbouncer.ini' (line 18: Can't find property '["postgresql.port"]')
   - Unable to render jobs for instance group 'rdpgnr1'. Errors are:
     - Unable to render templates for job 'rdpgd-service'. Errors are:
       - Error filling in template 'env' (line 51: Can't find property '["postgresql.port"]')
       - Error filling in template 'haproxy.cfg' (line 13: Can't find property '["haproxy.timeout_connect"]')
       - Error filling in template 'haproxy.cfg.header' (line 6: Can't find property '["haproxy.max_conn"]')
       - Error filling in template 'pgbouncer.ini' (line 18: Can't find property '["postgresql.port"]')

This is due to the ERB templates listed above (in rdpgd-manager and rdpgd-service jobs) to use some properties from other jobs (as listed above) without specifying them in their respective job specs.

A simple fix would consist in listing all the necessary properties in jobs specs.

Could you please come up with a fixed version of this RDPG BOSH release?
Thanks!

Cheers