Skip to content

Missing version prefix 'v' interrupts file download on package installation #156

Description

@k-aleksandar

If we have files to download on installation with our package and if the version of the package is in the file url like this in the composer.json file:

"name": "vendor/package",
...
"extra": {
    "download-dist": [
        {
            "url": "https://github.com/vendor/package/releases/download/{$version}/dist.tar.gz",
            "path": "resources/dist"
        }
    ]
}

then the installation is interrupted with an error that the file could not be downloaded

In CurlDownloader.php line 674:
The "https://github.com/vendor/package/releases/download/5.73.24/dist.tar.gz" file could not be downloaded (HTTP/2 404 )

That missing version prefix 'v' is the issue, the correct url will be https://github.com/vendor/package/releases/download/v5.73.24/dist.tar.gz and because package versions coming from pricore are without 'v' we have an error, in the composer.lock file package versions are without the prefix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions