Skip to content

feat: add withdraw function#673

Merged
0xmad merged 1 commit into
mainfrom
feat/update-withdrawal
Oct 3, 2025
Merged

feat: add withdraw function#673
0xmad merged 1 commit into
mainfrom
feat/update-withdrawal

Conversation

@JohnGuilding

@JohnGuilding JohnGuilding commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

Description

Re-add withdrawal function with changes

  • Add withdraw function that can be called after a cooldown
  • Funds can only be sent to a preconfigured custodian (Can set this to a gitcoin wallet for production deploy) - this balances having an escape hatch, while also reducing trust assumptions of the owner.
  • Can call withdraw only after tallying is complete

Minor simplifications

  • Removes depositWindow not essential as deposits can stop after tallying is complete
  • Removes pause functionality - no longer needed as this contract will be audited

Other changes

  • Remove duringDepositWindow & afterDepositWindow modifiers
  • claim can be called directly after tallying finishes

Additional Notes

Related issue(s)

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

@JohnGuilding JohnGuilding requested a review from 0xmad October 3, 2025 14:01
@JohnGuilding JohnGuilding self-assigned this Oct 3, 2025
Comment thread packages/contracts/contracts/maci/Tally.sol Dismissed
Comment thread packages/contracts/contracts/maci/Tally.sol Dismissed
Comment thread packages/contracts/contracts/maci/Tally.sol Dismissed
Comment thread packages/contracts/contracts/maci/Tally.sol Dismissed
@NicoSerranoP

Copy link
Copy Markdown
Member

I think this PR did not git pull from main. It might be better to do that and create another PR

@0xmad 0xmad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnGuilding thanks, just one question and improvement

Comment thread packages/contracts/contracts/interfaces/IPayoutStrategy.sol
Comment thread packages/contracts/contracts/maci/Tally.sol Outdated
@JohnGuilding JohnGuilding force-pushed the feat/update-withdrawal branch from 5fc020f to faafa0e Compare October 3, 2025 18:34

@0xmad 0xmad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnGuilding thanks!

@0xmad 0xmad enabled auto-merge October 3, 2025 18:39
@0xmad 0xmad disabled auto-merge October 3, 2025 18:42
@JohnGuilding JohnGuilding force-pushed the feat/update-withdrawal branch from faafa0e to ec02543 Compare October 3, 2025 18:43
@0xmad 0xmad enabled auto-merge October 3, 2025 18:46
@0xmad 0xmad merged commit 853158e into main Oct 3, 2025
14 checks passed
@0xmad 0xmad deleted the feat/update-withdrawal branch October 3, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants