feat: add claim task for project payouts#677
Open
lordshashank wants to merge 1 commit into
Open
Conversation
JohnGuilding
approved these changes
Oct 6, 2025
JohnGuilding
left a comment
JohnGuilding
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Since we don't validate in other tasks like you have here, will leave it up to you whether you change validation to remove eslint-disable
0xmad
reviewed
Oct 6, 2025
Comment on lines
+11
to
+18
| /** | ||
| * Interface that represents claim task arguments | ||
| */ | ||
| interface IClaimParams { | ||
| poll: string; | ||
| tallyFile: string; | ||
| index: number; | ||
| } |
Collaborator
There was a problem hiding this comment.
Types should not be defined here
Contributor
Author
There was a problem hiding this comment.
There were types in initPoll task as well, where should I put them?
NicoSerranoP
approved these changes
Oct 7, 2025
Collaborator
|
@0xmad what do you think about the failing e2e test? |
Collaborator
|
E2E tests fail if it’s fork, we had the same situation with maci. |
lordshashank
force-pushed
the
feat/claim-script
branch
from
991844b to
92a028b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new Hardhat task for claiming payouts for a specific project, and registers it in the Hardhat configuration. The new
claimtask allows users to claim a payout by providing a poll ID, a tally file, and a project index, handling contract interactions and proof generation.New claim task functionality:
claimHardhat task intasks/runner/claim.tsthat enables claiming a payout for a project by reading tally data from a file, validating inputs, generating Merkle proofs, and interacting with theTallycontract to execute the claim transaction.claimtask inhardhat.config.tsso it is available as a CLI command.Confirmation
Important
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.