-
Notifications
You must be signed in to change notification settings - Fork 3
Triage deferred PR 165 review findings in packages/cli-old #171
Copy link
Copy link
Closed
Description
PR #165 still has several CodeRabbit findings against packages/cli-old, which we intentionally deferred because that package is a reference-only legacy scaffold and not the active publish target.
Deferred items to evaluate:
- data-source URL normalization and command wiring in
packages/cli-old/src/cli/add/data-source/* - OttoFMS login timeout promise settlement in
packages/cli-old/src/cli/ottofms.ts - awaiting async config updates in
packages/cli-old/src/cli/remove/data-source.ts - incomplete
better-authpath inpackages/cli-old/src/generators/auth.ts - import/runtime issues in
packages/cli-old/src/generators/fmdapi.ts,src/helpers/version-fetcher.ts,src/installers/clerk.ts, andsrc/index.ts - template/reference issues under
packages/cli-old/template/extras/*and_cursor/rules/*
Context: active packages/cli review items were handled separately; this issue exists so the deferred legacy-package findings remain tracked instead of disappearing with PR comment resolution.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels