Skip to content

Triage deferred PR 165 review findings in packages/cli-old #171

@eluce2

Description

@eluce2

PR #165 still has several CodeRabbit findings against packages/cli-old, which we intentionally deferred because that package is a reference-only legacy scaffold and not the active publish target.

Deferred items to evaluate:

  • data-source URL normalization and command wiring in packages/cli-old/src/cli/add/data-source/*
  • OttoFMS login timeout promise settlement in packages/cli-old/src/cli/ottofms.ts
  • awaiting async config updates in packages/cli-old/src/cli/remove/data-source.ts
  • incomplete better-auth path in packages/cli-old/src/generators/auth.ts
  • import/runtime issues in packages/cli-old/src/generators/fmdapi.ts, src/helpers/version-fetcher.ts, src/installers/clerk.ts, and src/index.ts
  • template/reference issues under packages/cli-old/template/extras/* and _cursor/rules/*

Context: active packages/cli review items were handled separately; this issue exists so the deferred legacy-package findings remain tracked instead of disappearing with PR comment resolution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions