Skip to content

Commit 27f87af

Browse files
authored
Merge pull request #215 from ptidejteam/fix/codebase_refactoring
Refactor Test Suite Structure, Naming, and Resource Handling in CITYdata
2 parents aa640ac + 0d5be14 commit 27f87af

145 files changed

Lines changed: 202 additions & 66237 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Middleware/src/main/java/ca/concordia/encs/citydata/producers/BuildingProducer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class BuildingProducer extends AbstractProducer<JsonObject> implements IP
2727

2828
public void setBuildingName(String buildingName) {
2929
if (buildingName != null) {
30-
this.filePath = "docs/examples/data/" + buildingName + "_building.json";
30+
this.filePath = "./src/test/resources/" + buildingName + "_building.json";
3131
} else {
3232
throw new InvalidParameterException("Please provide a building name to the producer.");
3333
}

Middleware/src/main/java/ca/concordia/encs/citydata/producers/EnergyConsumptionProducer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class EnergyConsumptionProducer extends AbstractProducer<JsonArray> imple
4040
public void setCity(String city) {
4141
this.city = city;
4242
if (this.city != null) {
43-
this.cityConsumptionDataset = "docs/examples/data/" + this.city + "_energy_consumption.parquet";
43+
this.cityConsumptionDataset = "./src/test/resources/" + this.city + "_energy_consumption.parquet";
4444
} else {
4545
throw new InvalidParameterException("Please provide a city name to the producer.");
4646
}
@@ -58,7 +58,7 @@ public void setClientId(Integer clientId) {
5858
this.clientId = clientId;
5959
}
6060

61-
private String buildQuery() {
61+
public String buildQuery() {
6262
final Object[] arr = new Object[4];
6363
final String baseQuery = "SELECT Identifiant as clientId, dateinterval as timestamp, energieactivelivree_kwh as consumptionKwh FROM '%s'";
6464
String preparedStmt = baseQuery + " WHERE Identifiant is not null";
@@ -82,7 +82,7 @@ private String buildQuery() {
8282
return String.format(preparedStmt, arr);
8383
}
8484

85-
private void validateParams() {
85+
public void validateParams() {
8686
final int MAX_QUERY_DAYS = 30;
8787
final LocalDateTime localStartDate = StringUtils.parseDate(this.startDatetime);
8888
final LocalDateTime localEndDate = StringUtils.parseDate(this.endDatetime);

Middleware/src/main/java/ca/concordia/encs/citydata/producers/GeometryProducer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class GeometryProducer extends AbstractProducer<String> implements IProdu
2020

2121
public void setCity(String city) {
2222
if (city != null) {
23-
jsonProducer = new JSONProducer("docs/examples/data/" + city + "_geometries.json", null);
23+
jsonProducer = new JSONProducer("./src/test/resources/" + city + "_geometries.json", null);
2424
} else {
2525
throw new InvalidParameterException("Please provide a city name to the producer.");
2626
}

Middleware/src/main/resources/Data/Data.csv

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)