Unload module causes crash

[tolitski]

When the command module unload is executed on chan_echolink, the entire asterisk system crashes.

[N4IRS]

While chasing this I found that chan_echolink is not the only module that segfaults on unload.
chan_voter and chan_tlb also segfault on unload. All three have the same code in unload_module
unload_crash.txt

In the text file I posted there is a log_warning that I added while debugging.

[KG7QIN]

It has been a while since I looked at the code for these, but the modules typically have the "old" and "new" hooks for registering themselves with Asterisk and provide routines for loading (setup) and unloading (cleanup).

it is very likely that the modules above are using an incorrect hook for unloading (likely due to a conditional compile directive) so the code that would cleanup before the module is unloaded is not included in the compiled binary, causing the segfault.

[tolitski]

Is it possible to remove these conditional statements as we are only using this for a specific version of asterisk? Best regards, Roselito De Los Reyes On Mar 21, 2017, at 8:05 PM, KG7QIN <notifications@github.com<mailto:notifications@github.com>> wrote: It has been a while since I looked at the code for these, but the modules typically have the "old" and "new" hooks for registering themselves with Asterisk and provide routines for loading (setup) and unloading (cleanup). it is very likely that the modules above are using an incorrect hook for unloading (likely due to a conditional compile directive) so the code that would cleanup before the module is unloaded is not included in the compiled binary, causing the segfault. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://github.com/AllStarLink/Asterisk/issues/6#issuecomment-288285222>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKghYySG-tvKTLC4AZrEPbqUGx2Wgf8aks5roI_jgaJpZM4MD5Q7>.

[KG7QIN]

Possibly, but what also needs to be done is to check to make sure that the cleanup routines are indeed freeing any memory/pointers that were allocated prior to telling Asterisk it can unload the module -- and causing the segfault.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.