From 8d1098660e6392a8983bfa3b57ea6c01318814f3 Mon Sep 17 00:00:00 2001 From: Saurabh Pandit Date: Mon, 7 Sep 2026 13:16:37 +0530 Subject: [PATCH] (maint) Handle puppetcore9-nightly -> puppet9-nightly collection conversion install_puppetserver.sh's fetch_collection() only special-cased puppetcore8-nightly (added in PA-7893 for the same class of bug). For puppetcore9-nightly it fell through to the generic branch and returned the collection unchanged ("puppetcore9"), so the script requested a nonexistent nightly repo RPM (puppetcore9-release-el-.noarch.rpm instead of puppet9-release-el-.noarch.rpm). Since the script never checks curl/rpm exit codes and unconditionally exits 0, this failed silently: `yum install puppetserver` found no package, but the task still reported success. Surfaced via puppetlabs-kubernetes#723 (MODULES-11735, Puppet 9 support): the RHEL/puppetcore9-nightly integration job failed much later in a before(:suite) hook with "Unit puppetserver.service not found", since the package was never actually installed. Co-Authored-By: Claude --- tasks/install_puppetserver.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tasks/install_puppetserver.sh b/tasks/install_puppetserver.sh index caf7fc7..60e788e 100644 --- a/tasks/install_puppetserver.sh +++ b/tasks/install_puppetserver.sh @@ -62,6 +62,9 @@ fetch_collection() { # Handle puppetcore8-nightly -> puppet8-nightly conversion if [[ "$1" == puppetcore8* ]]; then echo "${1/puppetcore8/puppet8}" + # Handle puppetcore9-nightly -> puppet9-nightly conversion + elif [[ "$1" == puppetcore9* ]]; then + echo "${1/puppetcore9/puppet9}" else myarr=() for x in $(echo "$1" | tr "-" "\n")