Request: Add Codefolding to sql highlighter

[rcnza]

Would it be possible to add code folding to the sql highlighter? I compared it with the pas highlighter and looked at SynGen, but without documentation it seems impossible to be done by anybody not already familiar with the SynEdit code.

[JaFi-cz]

I made some code folding in SQL earlier, but I don't know how is highlighter compatible with current SynEdit.
It's hard to do any senseful highlighting cause in SQL are not specific code block. And query in the query doesn't help it.

SynHighlighterSQL.zip

[rcnza]

Wow thank you! I look forward to testing it. It uses SynHighlighterHashEntries which looks like it is not part of the current SynEdit. Do you have a copy of the one required by it?

[JaFi-cz]

In this case use parts, marked as "codefolding" and transfer it into current SQL highlighter. They don't depends on highlighter keyword search mechanism.

[pyscripter]

@JaFi-cz Good to see you back!

[pyscripter]

@dados Could this be your second PR?

[JaFi-cz]

@pyscripter I still follow your effort, but time is against me.
How is it now if text contains very long lines? Even without highlighter it was terribly slow. When the line exceed about 32k of chars, Synedit doesn't load the file.

[pyscripter]

@JaFi-cz

I am not sure at when you tested, but this has been optimized a long time ago.

Quick test:

64MB file Lines 356K long

Here is very fast with syntax highlighting, scrollbar annotations and everything. Scrolling is smooth, loads fast, no delays in editing etc.

[pyscripter]

@JaFi-cz I am still looking forward to adding your generic highlighter with ini files. #45 (reply in thread).

[JaFi-cz]

@pyscripter if you have time to implement it, here is source

SynHighlighterGeneral.zip

[pyscripter]

@JaFi-cz It is going to be useful if you also contribute:

• The code that saves/loads to Ini files
• The Ini editor that could serve as a property editor
• Your collection of INI based highlighters

If you do, this will be a great addition to SynEdit.

[JaFi-cz]

@pyscripter First I have to update to the current Synedit. There is lot of work to rewrite all to indicators instead of drawing. To be honest, I didn't look at it yet, so I need to understand indicators concept first.
Then I need to get rid off as most of my modification as possible to be able simply take the Synedit versions.
If you want, I can send you all corresponding sources. When you want my INI collection, you know where to get it ;-)

[pyscripter]

@JaFi-cz
If you send me the code that saves/loads the highlighter to ini files and the visual editor of the ini files, I will integrate them to this repo with the highlighter. Then we can add the highlighters to the repo.

I will probably keep the existing one and rename yours to something like SynHighlighterGeneric (not sure yet).

I think this will massively increase the appeal of SynEdit.

[JaFi-cz]

@pyscripter Try to look at it. It's old code and should be written from the scatch...
Any functions as GetDialog() e.t.c. only creates standard TOpenDialog, so you can replace it. All links to main or child windows are not necessary for the functionality or editing, loading, saving. They are there to refresh open windows highlighters, if you edit used one.
If you will need anything, let me know here or directly on the mail.

Tmp.zip

[pyscripter]

Thanks!
That should be enough for the integration. This will be my next project!

[JaFi-cz]

@pyscripter if you need anything, let me know. Most of the time I am online