We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 151ab2d commit 72d35cfCopy full SHA for 72d35cf
3 files changed
release.py
@@ -193,7 +193,10 @@ def normalized(self) -> str:
193
194
@property
195
def branch(self) -> str:
196
- return "main" if self.is_alpha_release else f"{self.major}.{self.minor}"
+ if self.is_alpha_release or self.is_feature_freeze_release:
197
+ return "main"
198
+ else:
199
+ return f"{self.major}.{self.minor}"
200
201
202
def is_alpha_release(self) -> bool:
tests/test_release_tag.py
@@ -41,26 +41,31 @@ def test_tag_phase() -> None:
41
assert alpha.is_feature_freeze_release is False
42
assert alpha.is_release_candidate is False
43
assert alpha.is_final is False
44
+ assert alpha.branch == "main"
45
46
assert beta1.is_alpha_release is False
47
assert beta1.is_feature_freeze_release is True
48
assert beta1.is_release_candidate is False
49
assert beta1.is_final is False
50
+ assert beta1.branch == "main"
51
52
assert beta4.is_alpha_release is False
53
assert beta4.is_feature_freeze_release is False
54
assert beta4.is_release_candidate is False
55
assert beta4.is_final is False
56
+ assert beta4.branch == "3.13"
57
58
assert rc.is_alpha_release is False
59
assert rc.is_feature_freeze_release is False
60
assert rc.is_release_candidate is True
61
assert rc.is_final is False
62
+ assert rc.branch == "3.13"
63
64
assert final.is_alpha_release is False
65
assert final.is_feature_freeze_release is False
66
assert final.is_release_candidate is False
67
assert final.is_final is True
68
+ assert final.branch == "3.13"
69
70
71
def test_tag_committed_at_not_found() -> None:
tests/test_run_release.py
@@ -59,7 +59,9 @@ def test_invalid_extract_github_owner() -> None:
[
# Success cases
("3.15.0rc1", "3.15\n", does_not_raise()),
- ("3.15.0b1", "3.15\n", does_not_raise()),
+ ("3.15.0b3", "3.15\n", does_not_raise()),
+ ("3.15.0b2", "3.15\n", does_not_raise()),
+ ("3.15.0b1", "main\n", does_not_raise()),
("3.15.0a6", "main\n", does_not_raise()),
("3.14.3", "3.14\n", does_not_raise()),
("3.13.12", "3.13\n", does_not_raise()),
@@ -71,8 +73,8 @@ def test_invalid_extract_github_owner() -> None:
73
),
72
74
(
75
"3.15.0b1",
- "main\n",
- pytest.raises(ReleaseException, match="on main branch, expected 3.15"),
76
+ "3.15\n",
77
+ pytest.raises(ReleaseException, match="on 3.15 branch, expected main"),
78
79
80
"3.15.0a6",
0 commit comments