Skip to content

Commit 835a549

Browse files
committed
Allowlist AbstractEventLoop.create_unix_server stub vs runtime cleanup_socket mismatch
1 parent cd0bfbb commit 835a549

3 files changed

Lines changed: 15 additions & 0 deletions

File tree

stdlib/@tests/stubtest_allowlists/py313.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,11 @@ ntpath.join
8686
# Allowlist entries that cannot or should not be fixed; >= 3.13
8787
# =============================================================
8888

89+
# `cleanup_socket` was added in 3.13 to the concrete `_UnixSelectorEventLoop.create_unix_server`,
90+
# not to the abstract `AbstractEventLoop.create_unix_server`. The stub adds it on the abstract
91+
# method so code typing the loop as `AbstractEventLoop` can still pass `cleanup_socket=...`. See #15742.
92+
asyncio.events.AbstractEventLoop.create_unix_server
93+
8994
_pyrepl\..+ # The internal implementation of the REPL on py313+; not for public consumption
9095
codecs.backslashreplace_errors # Runtime incorrectly has `self`
9196
codecs.ignore_errors # Runtime incorrectly has `self`

stdlib/@tests/stubtest_allowlists/py314.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,11 @@ multiprocessing.managers._BaseDictProxy.__reversed__
120120
# Allowlist entries that cannot or should not be fixed; >= 3.13
121121
# =============================================================
122122

123+
# `cleanup_socket` was added in 3.13 to the concrete `_UnixSelectorEventLoop.create_unix_server`,
124+
# not to the abstract `AbstractEventLoop.create_unix_server`. The stub adds it on the abstract
125+
# method so code typing the loop as `AbstractEventLoop` can still pass `cleanup_socket=...`. See #15742.
126+
asyncio.events.AbstractEventLoop.create_unix_server
127+
123128
_pyrepl\..+ # The internal implementation of the REPL on py313+; not for public consumption
124129
codecs.backslashreplace_errors # Runtime incorrectly has `self`
125130
codecs.ignore_errors # Runtime incorrectly has `self`

stdlib/@tests/stubtest_allowlists/py315.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,11 @@ types.UnionType.__qualname__
152152
# Allowlist entries that cannot or should not be fixed; >= 3.13
153153
# =============================================================
154154

155+
# `cleanup_socket` was added in 3.13 to the concrete `_UnixSelectorEventLoop.create_unix_server`,
156+
# not to the abstract `AbstractEventLoop.create_unix_server`. The stub adds it on the abstract
157+
# method so code typing the loop as `AbstractEventLoop` can still pass `cleanup_socket=...`. See #15742.
158+
asyncio.events.AbstractEventLoop.create_unix_server
159+
155160
_pyrepl\..+ # The internal implementation of the REPL on py313+; not for public consumption
156161
codecs.backslashreplace_errors # Runtime incorrectly has `self`
157162
codecs.ignore_errors # Runtime incorrectly has `self`

0 commit comments

Comments
 (0)