From 4b5b55bc6a067b2d7c0db8a69c9692d4ec1bb7f8 Mon Sep 17 00:00:00 2001 From: emaiannone Date: Sun, 19 Jan 2020 15:23:37 +0100 Subject: [PATCH] Refactor Member Ignoring Method smell in LicenseActivity class --- .../asdtm/goodweather/LicenseActivity.java | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/app/src/main/java/org/asdtm/goodweather/LicenseActivity.java b/app/src/main/java/org/asdtm/goodweather/LicenseActivity.java index b459537c..c5c03bff 100644 --- a/app/src/main/java/org/asdtm/goodweather/LicenseActivity.java +++ b/app/src/main/java/org/asdtm/goodweather/LicenseActivity.java @@ -60,20 +60,20 @@ public boolean onOptionsItemSelected(MenuItem item) { return super.onOptionsItemSelected(item); } - private String readLicense(final InputStream inputStream) throws IOException { - InputStreamReader inputStreamReader = new InputStreamReader(inputStream); - BufferedReader reader = new BufferedReader(inputStreamReader); - StringBuilder builder = new StringBuilder(); - try { - String stringRead; - while ((stringRead = reader.readLine()) != null) { - builder.append(stringRead).append("\n"); - } - } catch (IOException e) { - e.printStackTrace(); - } finally { - reader.close(); - } - return builder.toString(); - } + private static String readLicense(final InputStream inputStream) throws IOException { + InputStreamReader inputStreamReader = new InputStreamReader(inputStream); + BufferedReader reader = new BufferedReader(inputStreamReader); + StringBuilder builder = new StringBuilder(); + try { + String stringRead; + while ((stringRead = reader.readLine()) != null) { + builder.append(stringRead).append("\n"); + } + } catch (IOException e) { + e.printStackTrace(); + } finally { + reader.close(); + } + return builder.toString(); + } }