Build failures

[sorawee]

Thank you for the tool!

I would like to note some issues that I encountered when trying to use the tool.

Problem with #![feature]

All commands failed with:

...
   Compiling halo2_proofs v0.3.0 (https://github.com/Analyzable-Halo2/pse-halo2.git#d271fafe)
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/ubuntu/.cargo/git/checkouts/halo2curves-8a97a9560d6bf8cd/2ef5a9a/src/lib.rs:1:1
  |
1 | #![feature(asm)]
  | ^^^^^^^^^^^^^^^^
...

It looks like there should be a rust-toolchain.toml file to indicate the version of Rust to be used. My workaround is to run rustup install nightly and passed the +nightly flag to commands.

korrekt

The README indicates "--no-default-features for the current setup where the default flag is set to use_zcash_halo2_proofs". However, cargo +nightly run --no-default-features --features use_zcash_halo2_proofs and cargo +nightly run --no-default-features are not equivalent. One fails, and one succeeds.

$ cargo +nightly run --no-default-features
   Compiling korrekt v0.1.0 (/home/ubuntu/halo2-analyzer/korrekt)
error[E0433]: failed to resolve: use of undeclared crate or module `permutation`
   --> korrekt/src/circuit_analyzer/analyzer.rs:245:23
    |
245 |         permutation: &permutation::keygen::Assembly,
    |                       ^^^^^^^^^^^ use of undeclared crate or module `permutation`
...

Benchmarks

To run benchmarks, I switched the patch in Cargo.toml as instructed. However, I still am completely unable to run the benchmarks directory. cargo +nightly run fails with:

error[E0432]: unresolved import `halo2_proofs::arithmetic::FieldExt`
 --> /home/ubuntu/.cargo/git/checkouts/halo2-analyzer-65ddbb74512c2932/d8612bf/korrekt/src/circuit_analyzer/abstract_expr.rs:2:5
  |
2 |     arithmetic::FieldExt as Field,
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `FieldExt` in `arithmetic`
  |
  = help: consider importing this trait instead:
          halo2curves::FieldExt
...