You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #41 skipped 25 tests across 7 bats files because the v4 dtcw wrapper changed the environment model and the tests still encode v3 behaviour. This issue tracks adapting the dtcw bats suite to the v4 model and un-skipping them.
Root cause (v4 behaviour changes)
local is a first-class environment — always detected and preferred. So the env list now reads local … (not none / sdk / docker), and Using environment: local.
Direct script invocation — v4 no longer forwards to an sdk-/docker-installed docToolchain, so the mock_doctoolchain / mock_docker call counts are 0.
./dtcw tasks succeeds where v3 exited non-zero (nothing installed → now local runs).
tasks - forward to local doctoolchain · overrule config with DTC_CONFIG_FILE
direct invocation / mock not called
pristine_environment.bats
no arguments shows usage · tasks uses local environment - shows install docToolchain · sdk tasks shows install SDKMAN!
local-runs / usage output
sdk_installation.bats
don't show how to install SDKMAN! · doctoolchain installed with sdk - java missing · tasks - forward to sdk doctoolchain · using local with sdk environment fails · using docker with sdk environment fails · installing docker has no side effects · using docker with sdk installation
sdk-forwarding / local-first / docker
All are marked with a skip "v4: …" reason in the source, so they are greppable: grep -rn 'skip "v4' test/.
Acceptance criteria
Each skipped test is either rewritten to assert the intended v4 behaviour, or removed if the scenario no longer exists in v4.
The intended v4 environment precedence is decided and documented (local vs. explicitly-requested sdk/docker).
Context
PR #41 skipped 25 tests across 7 bats files because the v4
dtcwwrapper changed the environment model and the tests still encode v3 behaviour. This issue tracks adapting the dtcw bats suite to the v4 model and un-skipping them.Root cause (v4 behaviour changes)
localis a first-class environment — always detected and preferred. So the env list now readslocal …(notnone/sdk/docker), andUsing environment: local.mock_doctoolchain/mock_dockercall counts are0../dtcw taskssucceeds where v3 exited non-zero (nothing installed → now local runs).assert_java_version_supported,dtcw:514) is bypassed, so unsupported-Java scenarios no longer error. ⟶ overlaps with v4: make the supported/installed Java version configurable (currently hard-pinned to 17) #42.Skipped tests to revisit
docker_environment.batsinstall_doctoolchain.batsnone→localinstall_java.batsnone→localjava_environment.batslocal_environment.batspristine_environment.batssdk_installation.batsAll are marked with a
skip "v4: …"reason in the source, so they are greppable:grep -rn 'skip "v4' test/.Acceptance criteria
grep -rn 'skip "v4' test/returns nothing.test/bats/bin/bats --filter-tags '!e2e' testis green without skips on ubuntu and macos.References
java_environmentskips): v4: make the supported/installed Java version configurable (currently hard-pinned to 17) #42