Иван Давыдов#2
Open
Ivan-Dyncan wants to merge 4 commits into
Hidden character warning
The head ref may contain hidden characters: "\u0418\u0432\u0430\u043d_\u0414\u0430\u0432\u044b\u0434\u043e\u0432"
Open
Conversation
railbotan
reviewed
Nov 18, 2021
|
|
||
| def findMidValue(i, j, size): | ||
| s=0 | ||
| global arr |
Owner
There was a problem hiding this comment.
Так делать не хорошо, лучше передавать аргументом в функцию
railbotan
reviewed
Nov 18, 2021
| def findMidValue(i, j, size): | ||
| global arr | ||
| matrix = arr[i:i + size, j:j + size, ::] | ||
| b = list(matrix.reshape(1, matrix.shape[0] * matrix.shape[1] * 3))[0] |
Owner
There was a problem hiding this comment.
Лишние действия, нужно было воспользоваться функцией sum библиотеки Numpy
Owner
|
На будущее папку .idea/ надо добавлять в .gitignore |
Owner
|
3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Здравствуйте, не сделал 4ый этап, поленился
И во 2ом (правильном) этапе код будет работать не всегда, только если повезет с размером сетки (size), не стал это исправлять, потому что в 3ем этапе все работает нормально